Skip to content

Commit

Permalink
Change appid from xournalpp.desktop (sic!) to com.github.xournalpp.xo…
Browse files Browse the repository at this point in the history
…urnalpp

This is more in line with the spec which requires a reverse DNS name.
  • Loading branch information
muelli committed Aug 16, 2019
1 parent 382b68b commit f7248ab
Show file tree
Hide file tree
Showing 7 changed files with 12 additions and 8 deletions.
10 changes: 5 additions & 5 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,7 @@ if (${CMAKE_SYSTEM_NAME} MATCHES "Linux")
message ("Installing desktop files")

# Install icons
install(FILES ui/pixmaps/xournalpp.svg
install(FILES ui/pixmaps/com.github.xournalpp.xournalpp.svg
DESTINATION ${CMAKE_INSTALL_PREFIX}/share/icons/hicolor/scalable/apps)

# Symlink are not easy to use with CMake, therefor simple install a copy...
Expand All @@ -248,9 +248,9 @@ if (${CMAKE_SYSTEM_NAME} MATCHES "Linux")
install(FILES ui/pixmaps/gnome-mime-application-x-xopt.svg
DESTINATION ${CMAKE_INSTALL_PREFIX}/share/icons/hicolor/scalable/mimetypes/)

install(FILES desktop/xournalpp.xml
install(FILES desktop/com.github.xournalpp.xournalpp.xml
DESTINATION ${CMAKE_INSTALL_PREFIX}/share/mime/packages)
install(FILES desktop/xournalpp.desktop
install(FILES desktop/com.github.xournalpp.xournalpp.desktop
DESTINATION ${CMAKE_INSTALL_PREFIX}/share/applications)
install(FILES desktop/x-xojpp.desktop
DESTINATION ${CMAKE_INSTALL_PREFIX}/share/mimelnk/application)
Expand All @@ -259,10 +259,10 @@ if (${CMAKE_SYSTEM_NAME} MATCHES "Linux")
install(FILES desktop/x-xopt.desktop
DESTINATION ${CMAKE_INSTALL_PREFIX}/share/mimelnk/application)

install(FILES desktop/xournalpp.thumbnailer
install(FILES desktop/com.github.xournalpp.xournalpp.thumbnailer
DESTINATION ${CMAKE_INSTALL_PREFIX}/share/thumbnailers)

install(FILES desktop/xournalpp.appdata.xml
install(FILES desktop/com.github.xournalpp.xournalpp.appdata.xml
DESTINATION ${CMAKE_INSTALL_PREFIX}/share/metainfo)

# TODO: Only package post install scripts with distro-specific packages
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
<?xml version="1.0" encoding="UTF-8"?>
<!-- Copyright 2019 Tobias Mueller <tobiasmue@gnome.org> -->
<component type="desktop">
<id>xournalpp.desktop</id>
<id>com.github.xournalpp.xournalpp</id>
<translation type="gettext">xournalpp</translation>
<name>Xournal++</name>
<summary>Take handwritten notes</summary>
Expand Down Expand Up @@ -62,7 +63,10 @@
<image>https://i.imgur.com/3uxu40d.png</image>
</screenshot>
</screenshots>
<launchable type="desktop-id">@app-id@.desktop</launchable>
<launchable type="desktop-id">com.github.xournalpp.xournalpp.desktop</launchable>
<provides>
<id>xournalpp.desktop</id>
</provides>
<update_contact>webmaster_AT_huberulrich.de</update_contact>
<content_rating type="oars-1.0"/>
<releases>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,5 +23,5 @@ Exec=xournalpp %f
Terminal=false
StartupNotify=true
MimeType=application/x-xoj;application/x-xojpp;application/x-xopp;application/x-xopt;application/pdf;
Icon=xournalpp
Icon=com.github.xournalpp.xournalpp
Categories=Office;GNOME;GTK;
File renamed without changes.
File renamed without changes.
File renamed without changes
File renamed without changes

0 comments on commit f7248ab

Please sign in to comment.