Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page Move up/down seemingly impossible without side panel open #2297

Open
barrybingo opened this issue Oct 1, 2020 · 2 comments
Open

Page Move up/down seemingly impossible without side panel open #2297

barrybingo opened this issue Oct 1, 2020 · 2 comments
Labels

Comments

@barrybingo
Copy link

Is your feature request related to a problem? Please describe.
I use xournalpp without the sidebar and recently spent a long time trying to figure out how, or if it was possible, to reorder pages. Looking through the wiki and web site and I could not find any mention but some issues here said "right click on the page and select move up" but right clicking on a page's blank area did nothing for me except raise blood pressure.

Eventually I stumbled upon the sidebar.

Describe the solution you'd like
Selecting a page or object on a page highlights that page and it's border goes red to indicate it is the active page.
Menu commands such as "new page before" "new page after" work on this active page's index so...

I propose adding menu command "Move page up" and "Move page down" to the Journal menu.

Describe alternatives you've considered
Right clicking on a page brings up a context menu with Journal menu and such things as "Move up"

Additional context
Would be helpful to add something in the wiki or on the website guide, though I'm not sure which is used most or maintained. Anyway this issue is at least searchable for people to find.

@rolandlo rolandlo added the papercut User can get around easily... but can be annoying. label Oct 1, 2020
@rolandlo
Copy link
Member

The wiki is more complete, the work-in-progress website is more up to date but still highly incomplete. Everyone is invited to contribute, though.

@PraveenKum11
Copy link

Hi there,
I tried to add the Move Page Up/Down widget in the journal menu, I was able to implement it by mosty reusing the code for Move up/down in the side bar menu, as of now it works with undo/redo feature.

But I am having a hard time implementing - making the widgets active and deactive depending on the page number. I have the updateMoveUpPageButton() called at every place where updateDeletePageButton() was called but that does not handle the case when a page is selected by the user, so is there a way to handle that ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants