Font selection not working (From SF #129)

[wbrenna]

for Xournal++ 0.9.1
There seems to be no effect from Tools > Text Font. It neither changes the font of subsequent text input, nor does it change the font of a selected bit of text.
The only way I find to change font, is by editing it manually in ./xournalpp/settings.xml. But that just changes the default font, and does not allow for comfortably using multiple fonts in one document.

[wbrenna]

This bug does not appear for me on Fedora 15, though I do get a PANGO warning:

(xournalpp:11126): Pango-WARNING **: failed to choose a font, expect ugly output. engine-type='PangoRenderFc', script='common'

[wbrenna]

I can't replicate this problem so I'll close this for now.

[x2b]

I think that the callback is not connected properly. This should work as a fix:

x2b@546fbbc

[wbrenna]

Putting this fix into the next commit (I still can't replicate this bug so hopefully someone else can check).

PS What did you use to alter the indentation in your commit x2b/xournalpp@282ef2788, @x2b? I can't easily patch it into master because it was applied to addpoppler, and because of that git am is breaking on all of your patches. Probably just doing what you did on master will catch things up.

[x2b]

Well, as I mentioned in the commit, I used "artistic style" (http://astyle.sourceforge.net/):

astyle --recursive "*.h" "*.cpp" --style=allman \
                                 --indent=tab \
                                 --indent-namespaces \
                                 --indent-preprocessor \
                                 --indent-col1-comments \
                                 --min-conditional-indent=0 \
                                 --pad-oper \
                                 --align-pointer=type \
                                 --align-reference=type \
                                 --break-after-logical \
                                 --max-code-length=80 \
                                 --max-instatement-indent=120

I think it is a quite powerful tool. I generally work alone on software projects, I realize now that unilaterally changing pretty much every single file might not have been such a good idea...

However, I would still like to fix those insane includes (#include "../../model/PageRef.h"). I think this can be done automatically as well.

[wbrenna]

You're right, I'm impressed with astyle. If you find the command to fix includes let me know and I can apply it starting from master to avoid merge conflicts!

I'll take your word that this callback was a fix for the font problem and close this bug.