Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quick Rescale loses Current Page #3

Closed
wbrenna opened this issue Aug 20, 2013 · 3 comments
Closed

Quick Rescale loses Current Page #3

wbrenna opened this issue Aug 20, 2013 · 3 comments
Labels
bug

Comments

@wbrenna
Copy link
Contributor

wbrenna commented Aug 20, 2013

If you quickly zoom in/out the current page will be lost and the document view will switch to the first page.
@wbrenna
Copy link
Contributor Author

wbrenna commented Sep 14, 2013

I think this is a tricky bug. It looks like because the fireZoomChanged call in ZoomControl cannot lock the document, in some cases the zoom updates before the XournalView is able to find the current page and keep aligned to its top.

This might be able to be mitigated by locking the document frequently in the XournalView updater, or it might be fixed by scrolling within the ZoomControl as well.

@wbrenna
Copy link
Contributor Author

wbrenna commented Sep 14, 2013

I believe I was mistaken about this. While the above is still plausible it looks like the main player is a bug where if the zoom is greater than the "fit" zoom (i.e. pages are greater than the width of the window), the getCurrentPage tends to return zero, the start of the document.

@wbrenna
Copy link
Contributor Author

wbrenna commented Sep 14, 2013

Appears to have been a simple bug - a typo "y" should be "x" in Layout.cpp.

wbrenna added a commit that referenced this issue Sep 14, 2013
@wbrenna
A simple fix correcting issue #3.
693aaff
@wbrenna wbrenna closed this as completed Sep 14, 2013
@sadid sadid mentioned this issue Feb 10, 2015
Closed
andreasb242 pushed a commit that referenced this issue Apr 21, 2015
@MarekPikula
Fixed "Recent documents not showing" #3 bug from MarPiRK/xournalpp
15108da 
Fixed last save path when "Recent documents" is chosen in Open dialog. Rewritten recent documents with strings and paths.
andreasb242 pushed a commit that referenced this issue Nov 22, 2018
@siliconninja
Merge pull request #3 from xournalpp/master
b755f76 
Merge Latest Changes
@simonsimon006 simonsimon006 mentioned this issue Mar 2, 2019
Closed
@13hannes11 13hannes11 mentioned this issue Apr 28, 2019
Closed
@GammaPi GammaPi mentioned this issue May 29, 2019
Closed
@nicolae-stroncea nicolae-stroncea mentioned this issue Sep 18, 2019
Closed
@lehmanju lehmanju mentioned this issue Sep 28, 2019
Open
markromanmiller added a commit to markromanmiller/xournalpp that referenced this issue Dec 20, 2019
@markromanmiller
formatting try xournalpp#3
b214522
Febbe added a commit to Febbe/xournalpp that referenced this issue Jan 7, 2020
@Febbe
fixup attempt xournalpp#3
f671ec6
@bitsandscraps bitsandscraps mentioned this issue May 14, 2020
Closed
@simonb02 simonb02 mentioned this issue May 26, 2020
Closed
@deddc23efb deddc23efb mentioned this issue Jul 4, 2020
Closed
@beijoca beijoca mentioned this issue Sep 1, 2020
Closed
@sonukuldeep sonukuldeep mentioned this issue Sep 16, 2020
Closed
@maximilianduell maximilianduell mentioned this issue Dec 6, 2020
Closed
@nicolae-stroncea nicolae-stroncea mentioned this issue Feb 28, 2021
Closed
@glavagnoli glavagnoli mentioned this issue Oct 22, 2021
Closed
@KlumpRasmus KlumpRasmus mentioned this issue Apr 25, 2023
Closed
@florianjansen florianjansen mentioned this issue Apr 26, 2023
Closed
@NinjaTuna007 NinjaTuna007 mentioned this issue Apr 26, 2023
Closed
@NinjaTuna007 NinjaTuna007 mentioned this issue May 7, 2023
Closed
@yasmah74 yasmah74 mentioned this issue May 18, 2023
Closed
@yadavmayank742 yadavmayank742 mentioned this issue Jun 8, 2023
Open
@HTRiepe HTRiepe mentioned this issue Jun 13, 2023
Open
@tjiagoM tjiagoM mentioned this issue Oct 24, 2023
Closed
@rschram rschram mentioned this issue Oct 26, 2023
Closed
@kaiserls kaiserls mentioned this issue Oct 26, 2023
Closed
@tmoerschell tmoerschell mentioned this issue Nov 4, 2023
Merged
@atantet atantet mentioned this issue Nov 7, 2023
Closed
@drussellluke-nam drussellluke-nam mentioned this issue Nov 18, 2023
Closed
@matiasmicheletto matiasmicheletto mentioned this issue Nov 20, 2023
Closed
@fewTheRememberless fewTheRememberless mentioned this issue Nov 22, 2023
Closed
@vw-anna vw-anna mentioned this issue Nov 27, 2023
Closed
@DarkShadow4 DarkShadow4 mentioned this issue Nov 29, 2023
Closed
@tmoerschell tmoerschell mentioned this issue Dec 8, 2023
Open
@lisboajeff lisboajeff mentioned this issue Dec 9, 2023
Closed
@Anthony01998 Anthony01998 mentioned this issue Dec 12, 2023
Open
@Lisbang Lisbang mentioned this issue Dec 16, 2023
Closed
@yasmah74 yasmah74 mentioned this issue Dec 18, 2023
Closed
@JohnJayMcKaye JohnJayMcKaye mentioned this issue Dec 18, 2023
Closed
@a-sad-dan a-sad-dan mentioned this issue Dec 30, 2023
Closed
@dh2pp dh2pp mentioned this issue Jan 17, 2024
Closed
@huncut2016 huncut2016 mentioned this issue Jan 28, 2024
Open
@manu-vm manu-vm mentioned this issue Feb 9, 2024
Closed
@hiptmair hiptmair mentioned this issue Feb 29, 2024
Closed
@majorace majorace mentioned this issue Apr 9, 2024
Closed
@01-1 01-1 mentioned this issue Apr 20, 2024
Closed
@Heldingar Heldingar mentioned this issue Apr 29, 2024
Closed
@IlyaSulli IlyaSulli mentioned this issue May 4, 2024
Closed
@galk-research galk-research mentioned this issue May 10, 2024
Closed
@rajneeshXpandey rajneeshXpandey mentioned this issue May 16, 2024
Closed
@jani18003 jani18003 mentioned this issue May 18, 2024
Open
@BHANUPRATAPNITR BHANUPRATAPNITR mentioned this issue May 22, 2024
Closed
@ivanakcheurov ivanakcheurov mentioned this issue May 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wbrenna