Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The first point of Highlighter strokes has a pressure value #3651

Closed
bhennion opened this issue Dec 9, 2021 · 0 comments · Fixed by #3652 or #3653
Closed

The first point of Highlighter strokes has a pressure value #3651

bhennion opened this issue Dec 9, 2021 · 0 comments · Fixed by #3652 or #3653
Labels
bug priority::high regression This issue is about a regression from the previous release; or this PR fixes a regression.

Comments

@bhennion
Copy link
Contributor

bhennion commented Dec 9, 2021 •
edited

Affects versions :

Describe the bug
On a pressure sensitive device (or with pressure inference), the first point of highlighter strokes gets a pressure value assigned. This leads to stroke::hasPressure to return true, thus messing up saved files by adding a useless array of pressure values.

To Reproduce
Create a highlighter stroke with a pressure sensitive device, save and inspect the file.

A fix is coming soon :-)
@bhennion bhennion added the bug label Dec 9, 2021
bhennion added a commit to bhennion/xournalpp that referenced this issue Dec 9, 2021
@bhennion
Fix xournalpp#3651 - remove pressure value on Highlighter strokes fir…
55663e2 
…st point
@bhennion bhennion linked a pull request Dec 9, 2021 that will close this issue
Fix #3651 - remove pressure value on Highlighter strokes first point #3652
Merged
@bhennion bhennion added priority::high regression This issue is about a regression from the previous release; or this PR fixes a regression. labels Dec 9, 2021
bhennion added a commit to bhennion/xournalpp that referenced this issue Dec 9, 2021
@bhennion
Fix xournalpp#3651 - remove pressure value on Highlighter strokes fir…
573c3da 
…st point
bhennion added a commit that referenced this issue Dec 10, 2021
@bhennion
Fix #3651 - remove pressure value on Highlighter strokes first point
01737d1
@bhennion bhennion linked a pull request Dec 10, 2021 that will close this issue
Merge release branch into master #3653
Merged
@rolandlo rolandlo mentioned this issue Feb 12, 2022
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug priority::high regression This issue is about a regression from the previous release; or this PR fixes a regression.
Projects
None yet
Milestone
No milestone
1 participant
@bhennion