Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support GTK3+ #4

Closed
wbrenna opened this issue Aug 20, 2013 · 5 comments
Closed

Support GTK3+ #4

wbrenna opened this issue Aug 20, 2013 · 5 comments

Comments

@wbrenna
Copy link
Contributor

wbrenna commented Aug 20, 2013

There are a large number of these visible as warnings during make. They should be updated. Ideally to support GTK3+ once it's in common use (I don't want to break backwards compatibility).

@wbrenna wbrenna closed this as completed in 7b5514f Sep 8, 2013
wbrenna added a commit that referenced this issue Sep 8, 2013
@wbrenna
Copy link
Contributor Author

wbrenna commented Oct 18, 2013

This was accidentally closed. The deprecated calls are mostly:

g_mutex_new();
g_mutex_free(GMutex*);
g_cond_new();
g_cond_free(GCond*);
gdk_pixbuf_unref(GdkPixBuf*);
g_thread_init(gpointer);

@wbrenna wbrenna reopened this Oct 18, 2013
@wbrenna
Copy link
Contributor Author

wbrenna commented Nov 21, 2013

I think eventually gdk_threads_enter() and gdk_threads_leave() will be deprecated. Therefore I think this enhancement should be labelled "support gtk3+". Not in this milestone but hopefully in the next year :)

@wbrenna
Copy link
Contributor Author

wbrenna commented Dec 23, 2013

This has been partially updated through the pull request of x2b. I've put the most cutting edge work in the branch gtk3 - please use that branch if you're going to work on gtk3+ support!

@wbrenna
Copy link
Contributor Author

wbrenna commented Feb 11, 2014

I've done some more research into what needs to be done. This list is incomplete and may be updated as we go, but:

  • Change gtk+-2.0 to gtk+-3.0 in configure.ac
  • Figure out how to get rid of the <gdk/gdktypes.h> header (GTK3 only supports a few headers)
  • Migrate from libglade-2.0 to GTKBuilder (libglade3 does not seem to be supported by e.g. Ubuntu 13.10, but it can be used to convert .glade files to GTKBuilder files, the recommended step)
  • Change GDK_* keys to GDK_KEY_* (e.g. GDK_Home needs to be updated)
  • gdk_drawable has been retired: src/util/Util.cpp: gdk_drawable_set_colormap(GDK_DRAWABLE (pixmap), will need to be updated to a gdk_window call, I think. See https://developer.gnome.org/gtk3/stable/ch24s02.html#id-1.6.3.4.6.

Since this won't be backwards compatible and likely won't compile for a while, I've created a branch gtk3. Please use this branch if you want to experiment!

andreasb242 pushed a commit that referenced this issue Apr 21, 2015
 in MarPiRK/xournalpp)

Now segfault while exporting to PDF.
@andreasb242
Copy link
Contributor

Master is now at GTK3

Febbe added a commit to Febbe/xournalpp that referenced this issue Jan 7, 2020
@yasmah74 yasmah74 mentioned this issue May 18, 2023
@rschram rschram mentioned this issue Oct 26, 2023
@dh2pp dh2pp mentioned this issue Jan 17, 2024
@majorace majorace mentioned this issue Apr 9, 2024
@01-1 01-1 mentioned this issue Apr 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants