Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load image with specific size #4183

Open
youngminpark2559 opened this issue Aug 2, 2022 · 3 comments
Open

Load image with specific size #4183

youngminpark2559 opened this issue Aug 2, 2022 · 3 comments

Comments

@youngminpark2559
Copy link

Is your feature request related to a problem? Please describe.
When I load large size images, I should always resize them into small size

Describe the solution you'd like

  • Memorizing the size of image which was last loaded, and when image is loaded newly, this image should be loaded with the memorized size
  • Or, it would be great if I could specify certain area or region. After that I use ctrl+shift+i or drag-and-drop to load image
    Loaded image onto that region should have the specific designated size
@dov
Copy link

dov commented Sep 8, 2022

I agree with this. I was just about to open a feature request about something very similar.

Here is my suggested change:

  • When in image mode and clicking on the canvas you will not get a file select dialog immediately.
  • The mouse click should starts the dragging of an on canvas rectangle.
  • On mouse release When the file select dialog is opened.
  • After selecting the image, it will be rescaled to fit into the dragged rectangle previously chosen and then put on the canvas.

@ysngshn
Copy link

ysngshn commented Nov 21, 2022

At least it would be nice to have a consistent image insert size based on image resolution and pdf page size/DPI, etc. I am trying to insert the same signature saved as png and depending on where I click, it is inserted in a different size.

@p0mm
Copy link
Contributor

p0mm commented May 25, 2023

I really like the idea with specifying the area for the image before selecting the image -> I would like to implement this!
I also agree that image insert size should be consistent, i have played around with inserting images:

add_image_behavior.mp4

While there is reasons for the way xournalpp currently does it (zoom level & how close to the edge one adds an image) it doesn't feel very intuitive and i hope to improve it:

  • maybe account for zoom? most users probably aren't working with 100% zoom, so pictures added will always be larger / smaller when they are added with original size for 100% zoom -> this could be changed to original size at current zoom?
  • allow user to grab and move image directly after inserting it (currently you add the same image again? which feels buggy)
  • don't make the image smaller just because it was added closer to the edge, let the user decide to move or resize the image

I hope to open a PR soon, please feel welcome to suggest alternative behavior if you have any ideas - I'd be willing to try and implement them as well, so we can choose the best behavior in the end :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants