Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Undo Create New Page/Layer is broken #5

Closed
wbrenna opened this issue Aug 20, 2013 · 1 comment
Closed

Undo Create New Page/Layer is broken #5

wbrenna opened this issue Aug 20, 2013 · 1 comment
Labels
bug

Comments

@wbrenna
Copy link
Contributor

wbrenna commented Aug 20, 2013

To reproduce just create a new page and try to undo that operation. Xournalpp freezes without a stacktrace.
@wbrenna
Copy link
Contributor Author

wbrenna commented Aug 23, 2013

This bug is a bit of a rabbit hole. From what I believe, it's due to a double-locking of the document that appears deep in functions that update the number of pages in the sidebar and in the window. I was able to get this undo working by removing these nested doc->lock() commands, but that's not a solution so I'll keep working at it. Somewhere near InsertDeletePage there might be a doc->lock() that needs to be safely disposed or at least, terminated early.

wbrenna added a commit that referenced this issue Aug 24, 2013
@wbrenna
Fixes bug #5. The double lock was cleanly disposed of!
d8e1f9f
wbrenna added a commit that referenced this issue Aug 24, 2013
@wbrenna
Should fix bug #5 for the layer insert as well.
40e3865
@wbrenna wbrenna closed this as completed Aug 24, 2013
@sadid sadid mentioned this issue Feb 10, 2015
Closed
andreasb242 pushed a commit that referenced this issue Apr 21, 2015
@MarekPikula
Possibly fix for bug #5 in MarPiRK/xournalpp
3e914a9 
Added new autoconf boost script (and removed old ones), removed unused m4 files.
@simonsimon006 simonsimon006 mentioned this issue Mar 2, 2019
Closed
@13hannes11 13hannes11 mentioned this issue Apr 28, 2019
Closed
@GammaPi GammaPi mentioned this issue May 29, 2019
Closed
@nicolae-stroncea nicolae-stroncea mentioned this issue Sep 18, 2019
Closed
@lehmanju lehmanju mentioned this issue Sep 28, 2019
Open
Febbe added a commit to Febbe/xournalpp that referenced this issue Jan 7, 2020
@Febbe
fixup attempt xournalpp#5
024611d
@bitsandscraps bitsandscraps mentioned this issue May 14, 2020
Closed
@simonb02 simonb02 mentioned this issue May 26, 2020
Closed
@deddc23efb deddc23efb mentioned this issue Jul 4, 2020
Closed
@beijoca beijoca mentioned this issue Sep 1, 2020
Closed
@sonukuldeep sonukuldeep mentioned this issue Sep 16, 2020
Closed
@maximilianduell maximilianduell mentioned this issue Dec 6, 2020
Closed
@nicolae-stroncea nicolae-stroncea mentioned this issue Feb 28, 2021
Closed
@glavagnoli glavagnoli mentioned this issue Oct 22, 2021
Closed
@KlumpRasmus KlumpRasmus mentioned this issue Apr 25, 2023
Closed
@florianjansen florianjansen mentioned this issue Apr 26, 2023
Closed
@NinjaTuna007 NinjaTuna007 mentioned this issue Apr 26, 2023
Closed
@NinjaTuna007 NinjaTuna007 mentioned this issue May 7, 2023
Closed
@yasmah74 yasmah74 mentioned this issue May 18, 2023
Closed
@yadavmayank742 yadavmayank742 mentioned this issue Jun 8, 2023
Open
@HTRiepe HTRiepe mentioned this issue Jun 13, 2023
Open
@Fefeffefe Fefeffefe mentioned this issue Jun 21, 2023
Closed
@Samanbaia Samanbaia mentioned this issue Jul 22, 2023
Closed
@rs0404 rs0404 mentioned this issue Jul 27, 2023
Closed
@ezaton ezaton mentioned this issue Oct 24, 2023
Closed
@tjiagoM tjiagoM mentioned this issue Oct 24, 2023
Closed
@rschram rschram mentioned this issue Oct 26, 2023
Closed
@kaiserls kaiserls mentioned this issue Oct 26, 2023
Closed
@tmoerschell tmoerschell mentioned this issue Nov 4, 2023
Merged
@atantet atantet mentioned this issue Nov 7, 2023
Closed
@drussellluke-nam drussellluke-nam mentioned this issue Nov 18, 2023
Closed
@matiasmicheletto matiasmicheletto mentioned this issue Nov 20, 2023
Closed
@fewTheRememberless fewTheRememberless mentioned this issue Nov 22, 2023
Closed
@vw-anna vw-anna mentioned this issue Nov 27, 2023
Closed
@DarkShadow4 DarkShadow4 mentioned this issue Nov 29, 2023
Closed
@tmoerschell tmoerschell mentioned this issue Dec 8, 2023
Open
@lisboajeff lisboajeff mentioned this issue Dec 9, 2023
Closed
@Anthony01998 Anthony01998 mentioned this issue Dec 12, 2023
Open
@Lisbang Lisbang mentioned this issue Dec 16, 2023
Closed
@yasmah74 yasmah74 mentioned this issue Dec 18, 2023
Closed
@JohnJayMcKaye JohnJayMcKaye mentioned this issue Dec 18, 2023
Closed
@a-sad-dan a-sad-dan mentioned this issue Dec 30, 2023
Closed
@dh2pp dh2pp mentioned this issue Jan 17, 2024
Closed
@huncut2016 huncut2016 mentioned this issue Jan 28, 2024
Open
@hiptmair hiptmair mentioned this issue Feb 29, 2024
Closed
@majorace majorace mentioned this issue Apr 9, 2024
Closed
@01-1 01-1 mentioned this issue Apr 20, 2024
Closed
@Heldingar Heldingar mentioned this issue Apr 29, 2024
Closed
@IlyaSulli IlyaSulli mentioned this issue May 4, 2024
Closed
@galk-research galk-research mentioned this issue May 10, 2024
Closed
@rajneeshXpandey rajneeshXpandey mentioned this issue May 16, 2024
Closed
@jani18003 jani18003 mentioned this issue May 18, 2024
Open
@ivanakcheurov ivanakcheurov mentioned this issue May 29, 2024
Open
@EntrigesFichtenholz EntrigesFichtenholz mentioned this issue Jun 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wbrenna