Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update stroke recognizer to preserve line endpoints. #3285

Merged
merged 10 commits into from
Aug 4, 2021
Merged

Update stroke recognizer to preserve line endpoints. #3285

merged 10 commits into from
Aug 4, 2021

Conversation

kenballus
Copy link
Contributor

@kenballus kenballus commented Jul 29, 2021 •
edited
Loading

Implements enhancement suggested in issue #3279.

Commit breakdown:

  • 43cc161: Changes stroke recognizer so that when a line is recognized, the endpoints are preserved a straight line is extended between them. Introduces a bug that makes it so nearly vertical/horizontal lines don't snap to the vertical/horizontal axis.
  • 831895c: Merge
  • b6dcf26: Removes an unnecessary "using std::map" from a header file, as specified in issue Known Bugs and Todo's #2354.
  • 6a5ce40: Fixes the bug introduced in 43cc161.
  • de2589d: Fixes formatting of if statement to satisfy clang formatting.

@kenballus
Copy link
Contributor Author

There are a lot of commits here, and I can imagine that this could clutter the commit history. I know just enough git to get by, so if you'd like me to reformat some of this, I'm happy to do that.

LittleHuba
LittleHuba requested changes Jul 29, 2021
View reviewed changes
Copy link
Member

@LittleHuba LittleHuba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work. Here are some pointers on stuff to improve.

src/control/shaperecognizer/ShapeRecognizer.cpp Outdated Show resolved Hide resolved
src/gui/toolbarMenubar/ToolPageLayer.h Outdated Show resolved Hide resolved
src/control/shaperecognizer/ShapeRecognizer.cpp Outdated Show resolved Hide resolved
@LittleHuba
Copy link
Member

The number of commits is not really important for this size of the PR. We can simply squash it once we merge it.

@LittleHuba LittleHuba merged commit 5b4bc64 into xournalpp:master Aug 4, 2021
jetSett pushed a commit to jetSett/xournalpp that referenced this pull request Oct 5, 2021
@kenballus
Update stroke recognizer to preserve line endpoints. (xournalpp#3285)
873160a 
* Update stroke recognizer so recognized lines preserve endpoints.

* Fix vertical/horizontal line drawing
@rolandlo rolandlo mentioned this pull request Dec 6, 2021
Closed
@rolandlo rolandlo mentioned this pull request Feb 12, 2022
Closed
8 tasks
@Technius Technius added this to the v1.1.1 milestone Feb 13, 2022
@Febbe Febbe mentioned this pull request Apr 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LittleHuba LittleHuba LittleHuba approved these changes

@rolandlo rolandlo rolandlo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.1.1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kenballus @LittleHuba @rolandlo @Technius