-
Notifications
You must be signed in to change notification settings - Fork 772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend input method check for gcin #3315
Extend input method check for gcin #3315
Conversation
This PR seems to exclude all input methods other than |
I don't really get the point of this PR as it moves from blocking one specific input method So it does obviously not really improve the situation of the author, but worsens the situation of everybody else not using Maybe instead help us to support |
You're right. I didn't know other input methods work normally with xournalpp. I'll change this PR to block |
I've applied clang-format! This looks good to me! Merging in 24 hours unless there are objections. |
* add @changhc to author list * check against unsupported im only * Apply clang-format Co-authored-by: Henry Heino <hheino@uw.edu>
This reverts commit e6bb8b7.
Following #470 and #530, this PR extends the input method check to cover any input method that is not ibus.
In my case, I'm using
gcin
, an input method for Traditional Chinese. This is not covered in the current check, so xournalpp crashes every time I try to add some text to my pdf documents. My change will make the check more comprehensive than checking only againstxim
.Edit: checking against
xim
andgcin
only now.Test output