Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend input method check for gcin #3315

Merged

Conversation

changhc
Copy link
Contributor

@changhc changhc commented Aug 7, 2021

Following #470 and #530, this PR extends the input method check to cover any input method that is not ibus.

In my case, I'm using gcin, an input method for Traditional Chinese. This is not covered in the current check, so xournalpp crashes every time I try to add some text to my pdf documents. My change will make the check more comprehensive than checking only against xim.

Edit: checking against xim and gcin only now.

Test output

$ echo $GTK_IM_MODULE
gcin
$ ./src/xournalpp
** Message: 18:15:22.754: TEXTDOMAINDIR = (null), PACKAGE_LOCALE_DIR = /usr/local/share/locale, chosen directory = /usr/local/share/locale            
                                                                                                                                                      
** (xournalpp:18484): WARNING **: 18:15:22.754: Unsupported input method: gcin, changed to: ibus                                                      
ALSA lib pcm_dmix.c:1089:(snd_pcm_dmix_open) unable to open slave                                                                                     
ALSA lib pcm.c:2642:(snd_pcm_open_noupdate) Unknown PCM cards.pcm.rear                                                                                
ALSA lib pcm.c:2642:(snd_pcm_open_noupdate) Unknown PCM cards.pcm.center_lfe                                                                          
ALSA lib pcm.c:2642:(snd_pcm_open_noupdate) Unknown PCM cards.pcm.side                                                                                
ALSA lib pcm_route.c:869:(find_matching_chmap) Found no matching channel map                                                                          
ALSA lib pcm_oss.c:377:(_snd_pcm_oss_open) Unknown field port                                                                                         
ALSA lib pcm_oss.c:377:(_snd_pcm_oss_open) Unknown field port                                                                                         
ALSA lib pcm_usb_stream.c:486:(_snd_pcm_usb_stream_open) Invalid type for card                                                                        
ALSA lib pcm_usb_stream.c:486:(_snd_pcm_usb_stream_open) Invalid type for card                                                                        
ALSA lib pcm_dmix.c:1089:(snd_pcm_dmix_open) unable to open slave                                                                                     
** Message: 18:15:22.788: Plugin "MigrateFontSizes" UI initialized 

@tattsan
Copy link
Contributor

tattsan commented Aug 8, 2021

This PR seems to exclude all input methods other than ibus. However I don't use ibus on Xournalpp, but uim. It is violent to "eliminate everything except ibus", isn't it?

@LittleHuba
Copy link
Member

LittleHuba commented Aug 8, 2021

I don't really get the point of this PR as it moves from blocking one specific input method xim) to blocking all input methods (including xim).

So it does obviously not really improve the situation of the author, but worsens the situation of everybody else not using gcin?

Maybe instead help us to support gcin or block this one additional input method.

@changhc
Copy link
Contributor Author

changhc commented Aug 8, 2021

You're right. I didn't know other input methods work normally with xournalpp. I'll change this PR to block gcin only.

@changhc changhc changed the title Extend input method check Extend input method check for gcin Aug 8, 2021
@personalizedrefrigerator
Copy link
Contributor

I've applied clang-format!

This looks good to me! Merging in 24 hours unless there are objections.

@personalizedrefrigerator personalizedrefrigerator added this to the 1.1.x milestone Sep 2, 2021
@personalizedrefrigerator personalizedrefrigerator merged commit e6bb8b7 into xournalpp:master Sep 3, 2021
jetSett pushed a commit to jetSett/xournalpp that referenced this pull request Oct 5, 2021
* add @changhc to author list

* check against unsupported im only

* Apply clang-format


Co-authored-by: Henry Heino <hheino@uw.edu>
Rio6 added a commit to Rio6/xournalpp that referenced this pull request Oct 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants