Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing typo #3518

Merged
merged 1 commit into from
Nov 10, 2021
Merged

Fixing typo #3518

merged 1 commit into from
Nov 10, 2021

Conversation

Varpie
Copy link
Contributor

@Varpie Varpie commented Oct 27, 2021

When opening Xournal++ after an update changing where the configuration files are located, users are greeted with a message that contains an error: it says "Due to a recent update, Xournal++ has changed where it's configuration files are stored."

With these changes, the message is corrected so that users are not greeted by a typo.

@LittleHuba
Copy link
Member

Please rebase on release-1.1 so we can include this within the next minor release.

@bhennion bhennion added this to the v1.1.1 milestone Oct 30, 2021
@personalizedrefrigerator
Copy link
Contributor

Merging (and squashing) in 24 hours unless there are any objections.

@bhennion
Copy link
Contributor

bhennion commented Nov 9, 2021

Merging (and squashing) in 24 hours unless there are any objections.

LGTM! Just think of rebasing to release-1.1 before merging this

@bhennion bhennion added the merge proposed Merge was proposed by maintainer label Nov 9, 2021
@personalizedrefrigerator personalizedrefrigerator changed the base branch from master to release-1.1 November 9, 2021 22:43
@personalizedrefrigerator personalizedrefrigerator changed the base branch from release-1.1 to master November 9, 2021 22:43
When opening Xournal++ after an update changing where the configuration files are located, users are greeted with a message that contains an error.
This commit fixes it.
@personalizedrefrigerator personalizedrefrigerator changed the base branch from master to release-1.1 November 9, 2021 22:57
@personalizedrefrigerator personalizedrefrigerator merged commit d88fb37 into xournalpp:release-1.1 Nov 10, 2021
@Varpie Varpie deleted the patch-1 branch November 24, 2021 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge proposed Merge was proposed by maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants