Set classic locale for PDF export link attributes #3551

bhennion · 2021-11-07T19:42:19Z

bhennion · 2021-11-07T21:56:43Z

Added some test and meaningful return values to detect if the cairo_surface ends up in failed status.

~~NB: those error messages do not seem to be caught by the Export jobs. This needs to change whenever someone tackles the overdue export job refactor.~~ Edit: this works now

This PR is ready for review. Testing on different platforms is necessary, as locale related things tend to be messy.

bhennion · 2021-11-08T18:08:48Z

/azp run create-installers

azure-pipelines · 2021-11-08T18:08:59Z

Azure Pipelines successfully started running 1 pipeline(s).

bhennion · 2021-11-08T18:12:48Z

(Ah, the Debian build fails with unable to locate gcc8)

LittleHuba · 2021-11-08T18:14:13Z

Please rebase once more. This is already fixed on master (#3547)For release-1.1 you'll have to cherry-pick those commits.

bhennion · 2021-11-08T18:32:27Z

/azp run create-installers

azure-pipelines · 2021-11-08T18:32:38Z

Azure Pipelines successfully started running 1 pipeline(s).

Photon89 · 2021-11-08T18:36:28Z

Testing on different platforms is necessary, as locale related things tend to be messy.

Confirm the fix on Manjaro Linux. Thanks!

bhennion · 2021-11-08T18:43:38Z

Please rebase once more. This is already fixed on master (#3547)For release-1.1 you'll have to cherry-pick those commits.

Thanks! I cherry-picked. I'll remove the commit before this is merged.

LittleHuba · 2021-11-08T18:45:18Z

We actually want this commit on release-1.1. So please cherry-pick this directly on the release branch and push it to the repository.

LittleHuba · 2021-11-08T18:47:37Z

The requested installers were generated successfully. The installers are available at:

Please be aware that these links are only valid for a limited time (~30 days).

bhennion · 2021-11-08T19:25:49Z

We actually want this commit on release-1.1. So please cherry-pick this directly on the release branch and push it to the repository.

Done.

rolandlo · 2021-11-09T22:29:05Z

I have tested the generated installers on Windows 10 and MacOS Catalina, exporting the pdf from the poppler issue and checking the exported file.
On Windows it works fine (and it did so before).
On MacOS the export produces an empty document with the PR. The export works on an older version (from October 23).

bhennion · 2021-11-10T06:23:09Z

I have tested the generated installers on Windows 10 and MacOS Catalina, exporting the pdf from the poppler issue and checking the exported file. On Windows it works fine (and it did so before). On MacOS the export produces an empty document with the PR. The export works on an older version (from October 23).

Thanks for testing!

I made sure we get an error popup when the pdf export fails, and I added some debug info in the terminal output. Could you get me what debug output you get? It looks like a bunch of this:

Link to "Aufgabe 4":
    * Locale=C (used for export)
      "page=2 pos=[70 74.92]"
    * Locale=fr_FR.UTF-8
      "page=2 pos=[70 74,92]"

It'd be interesting to also get this output on Windows and, say, Ubuntu (or any other distrib where the export worked before this PR).

bhennion · 2021-11-10T09:12:39Z

Here is a simpler test pdf, which also has utf8 strings in label names:
toc.pdf

bhennion · 2021-11-10T09:56:17Z

/azp run create-installers

bhennion · 2021-11-10T10:21:24Z

I found the source of the original problem (see this post).
I added some more debug (in the terminal). Anyone trying this PR out, please post you terminal output here with you OS/distribution and portaudio version.

rolandlo · 2021-11-11T06:34:47Z

On Windows 10 with Portaudio 19.07 the export works fine (tested with toc.pdf)

Roland@LAPTOP-1UD9QQRU MINGW64 /C/Program Files/Xournal++
$ bin/xournalpp.exe
** Message: 07:30:49.762: TEXTDOMAINDIR = (NULL), Platform-specific locale dir = C:\Program Files\Xournal++\bin\..\share\xournalpp\..\locale, chosen directory = C:\Program Files\Xournal++\bin\..\share\xournalpp\..\locale

** (xournalpp.exe:19356): WARNING **: 07:30:49.763: XournalMain: System default locale could not be set.
 - Caused by: locale::facet::_S_create_c_locale name not valid
 - Note that it is not supported to set the locale using mingw-w64 on windows.
 - This could be solved by compiling xournalpp with msvc
** Message: 07:30:49.821: Plugin "MigrateFontSizes" UI initialized
Fontconfig error: Cannot load default config file: No such file: (null)
** Message: 07:31:12.447: lastOpenPath set
** Message: 07:31:12.473: Datei: C:\Users\Roland\Downloads\toc.pdf

Before portaudio, locale was: German_Switzerland.1252
And now locale is: German_Switzerland.1252
Link to "First section":
    * Locale=C (used for export)
      "page=1 pos=[124.802 325.55]"
    * Locale=C
      "page=1 pos=[124.802 325.55]"
Link to "Second section":
    * Locale=C (used for export)
      "page=2 pos=[124.802 242.826]"
    * Locale=C
      "page=2 pos=[124.802 242.826]"
Link to "1.1: utf8:éà@€èêëêîüßČµτ∫Ω⊗⊕∞":
    * Locale=C (used for export)
      "page=1 pos=[124.802 499.883]"
    * Locale=C
      "page=1 pos=[124.802 499.883]"
Link to "1.2":
    * Locale=C (used for export)
      "page=2 pos=[124.802 125.798]"
    * Locale=C
      "page=2 pos=[124.802 125.798]"
** Message: 07:31:46.404: lastOpenPath set
** Message: 07:31:46.432: Datei: C:\Users\Roland\Downloads\toc_export.pdf

bhennion · 2021-11-11T07:30:10Z

A lot confuses me in this log...
First, this warning:

** (xournalpp.exe:19356): WARNING **: 07:30:49.763: XournalMain: System default locale could not be set.
 - Caused by: locale::facet::_S_create_c_locale name not valid
 - Note that it is not supported to set the locale using mingw-w64 on windows.

then

Before portaudio, locale was: German_Switzerland.1252

So even if std::locale::global(std::locale("")); fails, the C locale is set (but probably not the C++ locale). I'll add more detailled log to understand this.

Then, if the C locale is German_Switzerland.1252 and the locale used writing the attributes is C, how come the export works fine? Are floating points numbers in Swiss German written differently from in German? Are they with dots or commas?

I'll add more precise outputs to try and figure things out.

bhennion · 2021-11-11T09:39:13Z

I realized something:

** Message: 09:42:53.560: XournalMain::on_startup after initLocalisation: C locale = "fr_FR.UTF-8", C++ locale = "fr_FR.UTF-8", cout locale = "fr_FR.UTF-8"
      stringstream prints: 12 345,7
      cout prints:         12 345,7
      printf prints:       12345,67890

With any other locale than C, we are not even sure that a floating point number would be written as one word: it may contain white spaces when printed out via cout or any stringstream.

On the other hand, when cairo parses the string, it splits at white spaces and uses sscanf. This means that unless the locale is everywhere C, we should not pass a string from a stringstream to cairo.

I think the proper solution to the problem at hand is:

never set the C locale to anything else than C
use a stringstream with local locale C to write down the link attributes fed to cairo.

However, the C locale is use by g_message everywhere in the code, so the terminal messages would no longer get localized.

Any opinion?

rolandlo · 2021-11-11T09:59:05Z

Then, if the C locale is German_Switzerland.1252 and the locale used writing the attributes is C, how come the export works fine? Are floating points numbers in Swiss German written differently from in German? Are they with dots or commas?

Yes, indeed, floating point numbers in de_CH.UTF-8 are with a decimal point rather than a comma. Easy reproducer:

roland@roland-ThinkPad-X1-Yoga-3rd:~$ export LANG=en_EN.UTF-8
roland@roland-ThinkPad-X1-Yoga-3rd:~$ time

real	0m0,000s
user	0m0,000s
sys	0m0,000s
roland@roland-ThinkPad-X1-Yoga-3rd:~$ export LANG=de_DE.UTF-8
roland@roland-ThinkPad-X1-Yoga-3rd:~$ time

real	0m0,000s
user	0m0,000s
sys	0m0,000s
roland@roland-ThinkPad-X1-Yoga-3rd:~$ export LANG=de_CH.UTF-8
roland@roland-ThinkPad-X1-Yoga-3rd:~$ time

real	0m0.000s
user	0m0.000s
sys	0m0.000s
roland@roland-ThinkPad-X1-Yoga-3rd:~$ export LANG=fr_FR.UTF-8
roland@roland-ThinkPad-X1-Yoga-3rd:~$ time

real	0m0.000s
user	0m0.000s
sys	0m0.000s

By the way in Switzerland it depends on a lot of factors whether people use a comma or a decimal point. Personally I use a decimal point (but still pronounce it as Komma), and according to this wikipedia article that's how it should be in high schools (and universities) in canton Zurich. :-D

bhennion · 2021-11-11T10:15:15Z

Beware that your test only works if you do have the locale generated on your machine (and apparently you don't have fr_FR.UTF-8 or de_CH.UTF-8). Here, I get

[benjamin@flower xournalpp-fork]$ export LANG=en_EN.UTF-8
[benjamin@flower xournalpp-fork]$ time

real    0m0,000s
user    0m0,000s
sys     0m0,000s
[benjamin@flower xournalpp-fork]$ export LANG=en_US.UTF-8
[benjamin@flower xournalpp-fork]$ time

real    0m0.000s
user    0m0.000s
sys     0m0.000s
[benjamin@flower xournalpp-fork]$ export LANG=de_DE.UTF-8
[benjamin@flower xournalpp-fork]$ time

real    0m0.000s
user    0m0.000s
sys     0m0.000s
[benjamin@flower xournalpp-fork]$ export LANG=fr_FR.UTF-8
[benjamin@flower xournalpp-fork]$ time

real    0m0,000s
user    0m0,000s
sys     0m0,000s

because I don't have de_DE.UTF-8. After generating de_CH.UTF-8, I get

[benjamin@flower xournalpp-fork]$ export LANG=de_CH.UTF-8
[benjamin@flower xournalpp-fork]$ time

real    0m0,000s
user    0m0,000s
sys     0m0,000s

so commas, probably from another canton :-)

rolandlo · 2021-11-11T10:51:50Z

[benjamin@flower xournalpp-fork]$ export LANG=de_CH.UTF-8
[benjamin@flower xournalpp-fork]$ time

real    0m0,000s
user    0m0,000s
sys     0m0,000s

so commas, probably from another canton :-)

I must insist that decimal points are used in German speaking Switzerland:

Contrast to Germany:

I already had the de_CH.UFT-8 locale generated (and did it once more using locale-gen). It's still a decimal point.

rolandlo · 2021-11-11T21:52:56Z

On Windows 10 after commit da49fbc

Roland@LAPTOP-1UD9QQRU MINGW64 ~/xournalpp/build
$ src/xournalpp.exe
** Message: 22:49:54.590: XournalMain::on_startup before initLocalisation: C locale = "German_Switzerland.1252", C++ locale = "C", cout locale = "C"
      stringstream prints: 12345.7
      cout prints:         12345.7
** Message: 22:49:54.595: TEXTDOMAINDIR = (NULL), Platform-specific locale dir = C:\msys64\home\Roland\xournalpp\build\src\..\share\xournalpp\..\locale, chosen directory = C:\msys64\home\Roland\xournalpp\build\src\..\share\xournalpp\..\locale

** (xournalpp.exe:17228): WARNING **: 22:49:54.600: XournalMain: System default locale could not be set.
 - Caused by: locale::facet::_S_create_c_locale name not valid
 - Note that it is not supported to set the locale using mingw-w64 on windows.
 - This could be solved by compiling xournalpp with msvc
** Message: 22:49:54.600: XournalMain::on_startup after initLocalisation: C locale = "C", C++ locale = "C", cout locale = "C"
      printf prints:       12345.678900

      stringstream prints: 12345.7
      cout prints:         12345.7
** Message: 22:49:54.822: Plugin "MigrateFontSizes" UI initialized
      printf prints:       12345.678900


Before portaudio, C locale was: C, C++ locale was C, stringstream locale was C
And now C locale is: C, C++ locale is C, stringstream locale is C
      stringstream prints: 12345.7
      cout prints:         12345.7
** Message: 22:50:42.500: XojCairoPdfExport::populatePdfOutline: C locale = "C", C++ locale = "C", cout locale = "C"
      printf prints:       12345.678900

      stringstream prints: 12345.7
      cout prints:         12345.7
      printf prints:       12345.678900

Link to "First section":
    * stringstream Locale=C (used for export)
      "page=1 pos=[124.802 325.55]"
    * stringstream2 Locale=C
      "page=1 pos=[124.802 325.55]"
   ** C locale = "C" -- printf prints 12345.678900
Link to "Second section":
    * stringstream Locale=C (used for export)
      "page=2 pos=[124.802 242.826]"
    * stringstream2 Locale=C
      "page=2 pos=[124.802 242.826]"
   ** C locale = "C" -- printf prints 12345.678900
Link to "1.1: utf8:éà@€èêëêîüßČµτ∫Ω⊗⊕∞":
    * stringstream Locale=C (used for export)
      "page=1 pos=[124.802 499.883]"
    * stringstream2 Locale=C
      "page=1 pos=[124.802 499.883]"
   ** C locale = "C" -- printf prints 12345.678900
Link to "1.2":
    * stringstream Locale=C (used for export)
      "page=2 pos=[124.802 125.798]"
    * stringstream2 Locale=C
      "page=2 pos=[124.802 125.798]"

rolandlo · 2021-11-11T22:09:16Z

On Ubuntu 21.10 after commit da49fbc (export works):

roland@roland-ThinkPad-X1-Yoga-3rd:~/Dokumente/Programmierung/Reviews/xournalpp$ build/src/xournalpp 
** Message: 23:05:36.217: XournalMain::on_startup before initLocalisation: C locale = "de_CH.UTF-8", C++ locale = "C", cout locale = "C"
      stringstream prints: 12345.7
      cout prints:         12345.7
      printf prints:       12345.678900

** Message: 23:05:36.217: TEXTDOMAINDIR = (null), Platform-specific locale dir = /usr/local/share/xournalpp/../locale, chosen directory = /usr/local/share/xournalpp/../locale
** Message: 23:05:36.217: XournalMain::on_startup after initLocalisation: C locale = "C", C++ locale = "de_CH.UTF-8", cout locale = "de_CH.UTF-8"
      stringstream prints: 12'345.7
      cout prints:         12'345.7
      printf prints:       12345.678900

ALSA lib pcm.c:2660:(snd_pcm_open_noupdate) Unknown PCM cards.pcm.rear
ALSA lib pcm.c:2660:(snd_pcm_open_noupdate) Unknown PCM cards.pcm.center_lfe
ALSA lib pcm.c:2660:(snd_pcm_open_noupdate) Unknown PCM cards.pcm.side
ALSA lib pcm_route.c:877:(find_matching_chmap) Found no matching channel map
ALSA lib pcm_route.c:877:(find_matching_chmap) Found no matching channel map
ALSA lib pcm_route.c:877:(find_matching_chmap) Found no matching channel map
ALSA lib pcm_route.c:877:(find_matching_chmap) Found no matching channel map
ALSA lib pcm_oss.c:377:(_snd_pcm_oss_open) Unknown field port
ALSA lib pcm_oss.c:377:(_snd_pcm_oss_open) Unknown field port
ALSA lib pcm_usb_stream.c:486:(_snd_pcm_usb_stream_open) Invalid type for card
ALSA lib pcm_usb_stream.c:486:(_snd_pcm_usb_stream_open) Invalid type for card
** Message: 23:05:36.389: Plugin "QuickScreenshot" UI initialized
** Message: 23:05:36.390: Plugin "MigrateFontSizes" UI initialized
** Message: 23:05:36.390: Plugin "LayerActions" UI initialized
** Message: 23:05:36.390: Plugin "ColorCycle" UI initialized
Hello from Example: Plugin initUi called

Menu reference:
{
  ["menuId"] = "0", 
  ["toolbarId"] = "-1"
}
Example plugin registered

** Message: 23:05:36.390: Plugin "Example" UI initialized

Before portaudio, C locale was: C, C++ locale was de_CH.UTF-8, stringstream locale was de_CH.UTF-8
And now C locale is: C, C++ locale is de_CH.UTF-8, stringstream locale is de_CH.UTF-8
      stringstream prints: 12'345.7
      cout prints:         12'345.7
      printf prints:       12345.678900

** Message: 23:05:50.903: lastOpenPath set
** Message: 23:05:50.911: file: /home/roland/Downloads/toc.pdf
** Message: 23:06:09.635: XojCairoPdfExport::populatePdfOutline: C locale = "C", C++ locale = "de_CH.UTF-8", cout locale = "de_CH.UTF-8"
      stringstream prints: 12'345.7
      cout prints:         12'345.7
      printf prints:       12345.678900

Link to "First section":
    * stringstream Locale=C (used for export)
      "page=1 pos=[124.802 325.55]"
    * stringstream2 Locale=de_CH.UTF-8
      "page=1 pos=[124.802 325.55]"
   ** C locale = "C" -- printf prints 12345.678900
Link to "Second section":
    * stringstream Locale=C (used for export)
      "page=2 pos=[124.802 242.826]"
    * stringstream2 Locale=de_CH.UTF-8
      "page=2 pos=[124.802 242.826]"
   ** C locale = "C" -- printf prints 12345.678900
Link to "1.1: utf8:éà@€èêëêîüßČµτ∫Ω⊗⊕∞":
    * stringstream Locale=C (used for export)
      "page=1 pos=[124.802 499.883]"
    * stringstream2 Locale=de_CH.UTF-8
      "page=1 pos=[124.802 499.883]"
   ** C locale = "C" -- printf prints 12345.678900
Link to "1.2":
    * stringstream Locale=C (used for export)
      "page=2 pos=[124.802 125.798]"
    * stringstream2 Locale=de_CH.UTF-8
      "page=2 pos=[124.802 125.798]"
   ** C locale = "C" -- printf prints 12345.678900
** Message: 23:06:25.995: lastOpenPath set
** Message: 23:06:26.003: file: /home/roland/Downloads/toc_export.pdf

rolandlo · 2021-11-11T22:20:29Z

On macOS Catalina (export works now):

admin@admins-MacBook-Pro mac-setup % cd Xournal++.app
admin@admins-MacBook-Pro Xournal++.app % ./Contents/MacOS/xournalpp
2021-11-11 23:13:47.820 defaults[9453:39160] 
The domain/default pair of (.GlobalPreferences, AppleCollationOrder) does not exist
** Message: 23:13:48.573: XournalMain::on_startup before initLocalisation: C locale = "de_CH.UTF-8", C++ locale = "C", cout locale = "C"
      stringstream prints: 12345.7
      cout prints:         12345.7
      printf prints:       12345,678900

** Message: 23:13:48.573: TEXTDOMAINDIR = (null), Platform-specific locale dir = /Users/admin/xournalpp/mac-setup/Xournal++.app/Contents/MacOS/../Resources/share/locale, chosen directory = /Users/admin/xournalpp/mac-setup/Xournal++.app/Contents/MacOS/../Resources/share/locale
** Message: 23:13:48.574: XournalMain::on_startup after initLocalisation: C locale = "C", C++ locale = "", cout locale = ""
      stringstream prints: 12345,7
      cout prints:         12345,7
      printf prints:       12345.678900

** Message: 23:13:48.623: Plugin "MigrateFontSizes" UI initialized

Before portaudio, C locale was: C, C++ locale was , stringstream locale was 
And now C locale is: C, C++ locale is , stringstream locale is 
      stringstream prints: 12345,7
      cout prints:         12345,7
      printf prints:       12345.678900


(xournalpp-bin:9448): Pango-WARNING **: 23:13:49.175: couldn't load font "Times New Roman, Condensed Not-Rotated 12", modified variant/weight/stretch as fallback, expect ugly output.

(xournalpp-bin:9448): Gtk-WARNING **: 23:13:49.596: Drawing a gadget with negative dimensions. Did you forget to allocate a size? (node mark owner GtkScale)

(xournalpp-bin:9448): Gtk-WARNING **: 23:13:49.596: Drawing a gadget with negative dimensions. Did you forget to allocate a size? (node indicator owner GtkScale)
** Message: 23:14:08.307: lastOpenPath set
** Message: 23:14:08.308: Datei: /Users/admin/Pictures/toc.pdf
** Message: 23:14:26.831: XojCairoPdfExport::populatePdfOutline: C locale = "C", C++ locale = "", cout locale = ""
      stringstream prints: 12345,7
      cout prints:         12345,7
      printf prints:       12345.678900

Link to "First section":
    * stringstream Locale=C (used for export)
      "page=1 pos=[124.802 325.55]"
    * stringstream2 Locale=
      "page=1 pos=[124,802 325,55]"
   ** C locale = "C" -- printf prints 12345.678900
Link to "Second section":
    * stringstream Locale=C (used for export)
      "page=2 pos=[124.802 242.826]"
    * stringstream2 Locale=
      "page=2 pos=[124,802 242,826]"
   ** C locale = "C" -- printf prints 12345.678900
Link to "1.1: utf8:éà@€èêëêîüßČµτ∫Ω⊗⊕∞":
    * stringstream Locale=C (used for export)
      "page=1 pos=[124.802 499.883]"
    * stringstream2 Locale=
      "page=1 pos=[124,802 499,883]"
   ** C locale = "C" -- printf prints 12345.678900
Link to "1.2":
    * stringstream Locale=C (used for export)
      "page=2 pos=[124.802 125.798]"
    * stringstream2 Locale=
      "page=2 pos=[124,802 125,798]"
   ** C locale = "C" -- printf prints 12345.678900
** Message: 23:14:33.327: lastOpenPath set
** Message: 23:14:33.328: Datei: /Users/admin/Pictures/toc_export.pdf

(xournalpp-bin:9448): Gtk-WARNING **: 23:14:35.684: Drawing a gadget with negative dimensions. Did you forget to allocate a size? (node marks owner GtkScale)

(xournalpp-bin:9448): Gtk-WARNING **: 23:14:37.604: Drawing a gadget with negative dimensions. Did you forget to allocate a size? (node indicator owner GtkScale)
admin@admins-MacBook-Pro Xournal++.app %       "page=1 pos=[124.802 325.55]"                                                                                                         
    * stringstream2 Locale=                                                                                                                                      
      "page=1 pos=[124,802 325,55]"
   ** C locale = "C" -- printf prints 12345.678900                                                                                                              
Link to "Second section":
    * stringstream Locale=C (used for export)                                                                                                                    
      "page=2 pos=[124.802 242.826]"
    * stringstream2 Locale=                                                                                                                                     
      "page=2 pos=[124,802 242,826]"
   ** C locale = "C" -- printf prints 12345.678900                                                                                                               
Link to "1.1: utf8:éà@€èêëêîüßČµτ∫Ω⊗⊕∞":
    * stringstream Locale=C (used for export)                                                                                                                    
      "page=1 pos=[124.802 499.883]"
    * stringstream2 Locale=                                                                                                                                     
      "page=1 pos=[124,802 499,883]"
   ** C locale = "C" -- printf prints 12345.678900                                                                                                               
Link to "1.2":
    * stringstream Locale=C (used for export)                                                                                                                   
      "page=2 pos=[124.802 125.798]"
    * stringstream2 Locale=                                                                                                                                      
      "page=2 pos=[124,802 125,798]"
   ** C locale = "C" -- printf prints 12345.678900                                                                                                               
** Message: 23:14:33.327: lastOpenPath set
** Message: 23:14:33.328: Datei: /Users/admin/Pictures/toc_export.pdf                                                                                       

(xournalpp-bin:9448): Gtk-WARNING **: 23:14:35.684: Drawing a gadget with negative dimensions. Did you forget to allocate a size? (node marks owner GtkScale)

bhennion · 2021-11-13T18:48:49Z

@rolandlo Thanks a lot for your patience and testing!

I removed the debug outputs. This PR is now ready for review (provided the checks clear).

azure-pipelines · 2021-11-13T21:06:14Z

Azure Pipelines successfully started running 1 pipeline(s).

LittleHuba · 2021-11-13T21:20:34Z

The requested installers were generated successfully. The installers are available at:

Please be aware that these links are only valid for a limited time (~30 days).

rolandlo

LGTM

bhennion · 2021-11-14T17:45:48Z

Merging in 24h if no objection is raised

bhennion linked an issue Nov 7, 2021 that may be closed by this pull request

"BAD status: invalid tag name, attributes, or nesting" #3388

Closed

bhennion mentioned this pull request Nov 7, 2021

"BAD status: invalid tag name, attributes, or nesting" #3388

Closed

bhennion requested a review from rolandlo November 7, 2021 21:58

bhennion force-pushed the pr/Fix3388 branch from 71530a5 to 8ba3324 Compare November 8, 2021 19:25

bhennion added 3 commits November 10, 2021 07:14

Set classic locale for PDF export link attributes

be5f44c

Add success test for cairo surface setup in XojCairoPdfExport

889cb11

Display error message when pdf export fails

90c41f0

bhennion force-pushed the pr/Fix3388 branch from 8ba3324 to 9fb264f Compare November 10, 2021 06:14

This comment has been minimized.

Sign in to view

bhennion force-pushed the pr/Fix3388 branch from 01e131e to 78a825e Compare November 10, 2021 10:07

This comment has been minimized.

Sign in to view

Force C locale LC_NUMERIC to "C"

75b1b6f

bhennion force-pushed the pr/Fix3388 branch from da49fbc to 75b1b6f Compare November 13, 2021 18:47

rolandlo approved these changes Nov 14, 2021

View reviewed changes

bhennion added the merge proposed Merge was proposed by maintainer label Nov 14, 2021

bhennion merged commit e2a1f97 into xournalpp:release-1.1 Nov 15, 2021

bhennion deleted the pr/Fix3388 branch November 15, 2021 18:32

bhennion mentioned this pull request Nov 24, 2021

Remove global locale #3611

Open

Technius added this to the v1.1.1 milestone Feb 5, 2022

bhennion mentioned this pull request Jul 13, 2022

Pdf content disappears on export #2998

Open

Set classic locale for PDF export link attributes #3551

Set classic locale for PDF export link attributes #3551

Conversation

bhennion commented Nov 7, 2021

bhennion commented Nov 7, 2021 • edited

bhennion commented Nov 8, 2021

azure-pipelines bot commented Nov 8, 2021

bhennion commented Nov 8, 2021

LittleHuba commented Nov 8, 2021 • edited

bhennion commented Nov 8, 2021

azure-pipelines bot commented Nov 8, 2021

Photon89 commented Nov 8, 2021 • edited

bhennion commented Nov 8, 2021

LittleHuba commented Nov 8, 2021

LittleHuba commented Nov 8, 2021

bhennion commented Nov 8, 2021

rolandlo commented Nov 9, 2021

bhennion commented Nov 10, 2021

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

bhennion commented Nov 10, 2021

bhennion commented Nov 10, 2021 • edited

This comment has been minimized.

This comment has been minimized.

bhennion commented Nov 10, 2021

This comment has been minimized.

rolandlo commented Nov 11, 2021

bhennion commented Nov 11, 2021 • edited

bhennion commented Nov 11, 2021 • edited

rolandlo commented Nov 11, 2021

bhennion commented Nov 11, 2021

rolandlo commented Nov 11, 2021

rolandlo commented Nov 11, 2021

rolandlo commented Nov 11, 2021

rolandlo commented Nov 11, 2021

bhennion commented Nov 13, 2021

azure-pipelines bot commented Nov 13, 2021

LittleHuba commented Nov 13, 2021

rolandlo left a comment

Choose a reason for hiding this comment

bhennion commented Nov 14, 2021

bhennion commented Nov 7, 2021 •

edited

LittleHuba commented Nov 8, 2021 •

edited

Photon89 commented Nov 8, 2021 •

edited

bhennion commented Nov 10, 2021 •

edited

bhennion commented Nov 11, 2021 •

edited

bhennion commented Nov 11, 2021 •

edited