Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor setsquare to use MVC pattern #4211

Merged
merged 24 commits into from
Dec 17, 2022
Merged

Refactor setsquare to use MVC pattern #4211

merged 24 commits into from
Dec 17, 2022

Commits on Dec 15, 2022

  1. Refactor setsquare using the MVC pattern

    @rolandlo
    rolandlo committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    30de4de View commit details
    Browse the repository at this point in the history

  2. Minor formatting changes

    @rolandlo
    rolandlo committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    f963bdc View commit details
    Browse the repository at this point in the history

  3. Derive setsquare classes from geometryTool classes

    @rolandlo
    rolandlo committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    e78dd0e View commit details
    Browse the repository at this point in the history

  4. Minor simplification

    @rolandlo
    rolandlo committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    dc30e5d View commit details
    Browse the repository at this point in the history

  5. Fix highlighter and eraser strokes near geometry tool

    @rolandlo
    rolandlo committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    acadf56 View commit details
    Browse the repository at this point in the history

  6. Use CairoSaveGuards

    @rolandlo
    rolandlo committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    d00707c View commit details
    Browse the repository at this point in the history

  7. Refactor getMatrix

    @rolandlo
    rolandlo committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    a261150 View commit details
    Browse the repository at this point in the history

  8. Apply reviewer suggestions

    @rolandlo
    rolandlo committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    e506cd8 View commit details
    Browse the repository at this point in the history

  9. Compute repaint range in GeometryTool class

    @rolandlo
    rolandlo committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    8256abb View commit details
    Browse the repository at this point in the history

  10. Fix radius locking for setsquare

    @rolandlo
    rolandlo committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    f106be5 View commit details
    Browse the repository at this point in the history

  11. Fix scrolling in GeometryToolHandler

    @rolandlo
    rolandlo committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    adcd8f7 View commit details
    Browse the repository at this point in the history

  12. Cache geometry tool drawing into a mask

    @rolandlo
    rolandlo committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    2a54aec View commit details
    Browse the repository at this point in the history

  13. mark origin

    @rolandlo
    rolandlo committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    ef43310 View commit details
    Browse the repository at this point in the history

  14. remove undefined updateValues method

    @rolandlo
    rolandlo committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    d189777 View commit details
    Browse the repository at this point in the history

  15. Apply reviewer suggestions

    @rolandlo
    rolandlo committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    ad90e50 View commit details
    Browse the repository at this point in the history

  16. GeometryToolHandler -> GeometryToolInputHandler

    @rolandlo
    rolandlo committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    e8b2bbb View commit details
    Browse the repository at this point in the history

  17. Use RadialStroke and EdgeStroke

    @rolandlo
    rolandlo committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    9e30878 View commit details
    Browse the repository at this point in the history

  18. use unique_ptr for geometry tool related classes

    @rolandlo
    rolandlo committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    36edf6d View commit details
    Browse the repository at this point in the history

  19. Lock mutex in addStrokeToLayer

    @rolandlo
    rolandlo committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    707806b View commit details
    Browse the repository at this point in the history

  20. let Control own geometryToolController

    @rolandlo
    rolandlo committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    50bb9ad View commit details
    Browse the repository at this point in the history

  21. let InputContext own geometryToolInputHandler

    @rolandlo
    rolandlo committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    ca1f988 View commit details
    Browse the repository at this point in the history

  22. let Control own geometryTool

    @rolandlo
    rolandlo committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    5e4c481 View commit details
    Browse the repository at this point in the history

  23. Account for line width in tool range

    @rolandlo
    rolandlo committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    5a96bcc View commit details
    Browse the repository at this point in the history

  24. Apply more reviewer suggestions

    @rolandlo
    rolandlo committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    bf58c4c View commit details
    Browse the repository at this point in the history