Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More RAII cleanup #4788

Merged
merged 18 commits into from
Apr 10, 2023
Merged

More RAII cleanup #4788

merged 18 commits into from
Apr 10, 2023

Conversation

jhilmer
Copy link
Contributor

@jhilmer jhilmer commented Apr 7, 2023

Use RAII - to get rid of many g_object_unref

src/core/gui/MainWindow.cpp Outdated Show resolved Hide resolved
src/core/gui/MainWindow.cpp Outdated Show resolved Hide resolved
src/core/control/tools/ImageHandler.cpp Outdated Show resolved Hide resolved
src/core/control/xojfile/LoadHandler.cpp Outdated Show resolved Hide resolved
src/core/model/Document.cpp Outdated Show resolved Hide resolved
src/core/model/Document.cpp Outdated Show resolved Hide resolved
src/core/model/TexImage.cpp Outdated Show resolved Hide resolved
Co-authored-by: Benjamin Hennion <benjamin.hennion@wanadoo.fr>
@jhilmer jhilmer requested a review from bhennion April 7, 2023 17:35
@bhennion
Copy link
Contributor

bhennion commented Apr 8, 2023

I'll be squashing and merging in 24 hours unless an objection is raised.

@bhennion bhennion added the merge proposed Merge was proposed by maintainer label Apr 8, 2023
@bhennion bhennion merged commit b07ead4 into xournalpp:master Apr 10, 2023
@Technius Technius added this to the v1.2.0 milestone Apr 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge proposed Merge was proposed by maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants