-
Notifications
You must be signed in to change notification settings - Fork 772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Image Editing: Image Frames #4946
Draft
p0mm
wants to merge
12
commits into
xournalpp:master
Choose a base branch
from
p0mm:load_image_with_specific_size#4183
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Commits on Jun 28, 2023
-
Select Space before Adding Image
you can select space by dragging the mouse instead of clicking; image is then scaled down; still missing some visual and more options
Configuration menu - View commit details
-
Copy full SHA for b4a2ed4 - Browse repository at this point
Copy the full SHA b4a2ed4View commit details
Commits on Jul 3, 2023
-
Image can be scaled up too; no scaling occurs if selected space is 0
Configuration menu - View commit details
-
Copy full SHA for b53094e - Browse repository at this point
Copy the full SHA b53094eView commit details
Commits on Jul 4, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 7c7473f - Browse repository at this point
Copy the full SHA 7c7473fView commit details
Commits on Jul 11, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 13eea34 - Browse repository at this point
Copy the full SHA 13eea34View commit details -
Configuration menu - View commit details
-
Copy full SHA for 348d744 - Browse repository at this point
Copy the full SHA 348d744View commit details -
Configuration menu - View commit details
-
Copy full SHA for e9ca4f2 - Browse repository at this point
Copy the full SHA e9ca4f2View commit details
Commits on Jul 12, 2023
-
they can contain images & be moved and scaled with the selection tool currently working modes are 'fill' and 'scale down', with 'scale down' currently hardcoded in
Configuration menu - View commit details
-
Copy full SHA for ceabd90 - Browse repository at this point
Copy the full SHA ceabd90View commit details
Commits on Jul 23, 2023
-
allows imageFrames to be scaled without changing to selection tool; re-rendering is (temporarily) done via (costly) short-cut, I still need to figure that out
Configuration menu - View commit details
-
Copy full SHA for a540112 - Browse repository at this point
Copy the full SHA a540112View commit details
Commits on Jul 25, 2023
-
Logic to draw a partial View of an Image
this will be used by the Image Frame, but is located in ImageView (because it makes sense) and Image (to remember the surface & not recreate it every time)
Configuration menu - View commit details
-
Copy full SHA for 4c90a7f - Browse repository at this point
Copy the full SHA 4c90a7fView commit details
Commits on Jul 26, 2023
-
ImageFrames display only chosen part of image
general update to how the ImageFrames look & they are drawing partial images
Configuration menu - View commit details
-
Copy full SHA for 4d4b418 - Browse repository at this point
Copy the full SHA 4d4b418View commit details -
Configuration menu - View commit details
-
Copy full SHA for d73d5e9 - Browse repository at this point
Copy the full SHA d73d5e9View commit details
Commits on Aug 2, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 5bd1e19 - Browse repository at this point
Copy the full SHA 5bd1e19View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.