-
Notifications
You must be signed in to change notification settings - Fork 772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GTK4 compiling branch #5615
base: master
Are you sure you want to change the base?
GTK4 compiling branch #5615
Conversation
It now runs (but doesn't quite work). Note: the CI fails to build because I put gtk4 >= 4.10.1 in the CMakeFile. Lowering this number should pose no problem, in case you don't have an up-to-date enough setup. |
Oh, wow, that's awesome! Great job @bhennion ! I'm really excited! |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
713ae8a
to
d5164fc
Compare
This comment was marked as resolved.
This comment was marked as resolved.
d640a73
to
baaa7f8
Compare
This comment was marked as resolved.
This comment was marked as resolved.
fe1ba02
to
1887c63
Compare
This is now in a reasonably stable state. Everything works with a couple of exceptions (toolbar customization, touchpad pinch zoom, clipboard, plugins). |
Great work @bhennion! It's a giant step forward! We should also review your previous PR's that went into this PR, so that they can be merged into master. Moreover I think it's time for some testing of the features that are supposed to work. I will share my observations in this PR. |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Workaround a bug in gtk4: https://gitlab.gnome.org/GNOME/gtk/-/issues/4574
This is no longer based on any (other) PR. The diff is still gigantic. Most of it is in the .glade/.ui files but still: changes in
I'm not quite sure how to organize a review process on this kind of changes. Any idea? |
It doesn't run yet, but we're closing in, I think.This branch compiles (and links) and starts
but the .glade files need to be adapted before testing anything.edit: and worksThere are a couple of features I deactivated/commented out to get it to compile, so those need fixing either in gtk4, or before that, in gtk3 (e.g. the sidebar could be pre-ported).
Gdk-CRITICAL **: 21:20:45.390: gdk_key_event_get_keyval: assertion 'GDK_IS_EVENT_TYPE (event, GDK_KEY_PRESS) || GDK_IS_EVENT_TYPE (event, GDK_KEY_RELEASE)'
errorsNB: this branch is built on a merge of various PR's. Not really a pull request...