Call toString() even if objects do not implement lang.Value #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Idea based on xp-framework#312, however, I disagree that this is an information disclosure problem. Secret values should use the util.Secret class
thekid
commented
Aug 15, 2022
| nameof($test)." {\n}", | ||
| Objects::stringOf($test) | ||
| ); | ||
| $this->assertEquals('->{:recursion:}', Objects::stringOf($test)); |
There was a problem hiding this comment.
This is a behavioral change we cannot prevent, unfortunately.
|
In addition to XP core's 4'221 unittests, all 13'885 XP libraries' tests also pass with this change - the behavioral change doesn't have any impact here (although I'll admit I don't always test string representations thorougly...) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Idea based on #312, however, I disagree that this is an information disclosure problem. Secret values should use the util.Secret class, see #312 (comment)