security.SecureString -> util.Secret #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thekid
changed the title
thekid
added a commit
that referenced
this pull request
Dec 10, 2015
security.SecureString -> util.Secret
thekid
added a commit
that referenced
this pull request
Dec 10, 2015
kiesel
pushed a commit
that referenced
this pull request
Dec 18, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the extraction of the
securitypackage per xp-framework/rfc#293 users need to depend on an extra library for a single class. This pull request reintroduce the class to XP core.There are however subtle changes:
setCharacters()is removed, and the getter method is now namedreveal().The
security.SecureStringclass extends the newutil.Secretclass to enable seamless migration./cc @mikey179 & @kiesel