Update build scripts

[ignacio]

Hi! As mentioned in luarocks/luarocks#382, there is a fix to the appveyor install script. You might want to apply the fix to your script by hand, or you might want to update the whole appveyor integration.

Here is a job that installed busted correctly (but failed because I don't have any test file tu run).

[ignacio]

I see you've updated the scripts. Remember, you need to use LuaRocks HEAD until 2.2.3 is released (due to cmake support)

[xpol]

Does the cmake_geneartor="Visual Studio 12 2013" support x64 build?
https://github.com/keplerproject/luarocks/blob/master/src/luarocks/build/cmake.lua#L44 is a elseif not end and if.

[ignacio]

Yes, it does. What LuaRocks does is to add -DCMAKE_GENERATOR_PLATFORM=x64 to the command line.

[ignacio]

I'm running some tests now. It seems that I might have missed something in the script. Please hold on :)

[xpol]

👌

[xpol]

I think luarocks don't have -DCMAKE_GENERATOR_PLATFORM=x64 set since https://github.com/keplerproject/luarocks/blob/master/src/luarocks/build/cmake.lua#L44 is a elseif.

[ignacio]

Thank you. That was it. I couldn't understand why it started to fail once I corrected the configuration.

https://ci.appveyor.com/project/ignacio/lua-rapidjson/build/job/eqpn24grlbx2bbyf

Give me a minute, I'll fix in LR itself.

[xpol]

My fixes here works.
But I'd like to wait you fixes to luarocks and remove the platform tail for cmake_generator.

[ignacio]

Well, thanks for the PR. I'll add that, but I think the fix must not be done in LuaRocks. When you choose the generator, you can specify if you want 64 bits, so we should not second guess the user in this case. So, that elseif is ok. We'll need the platform tail for cmake_generator.

I'm polishing the fix you submitted so it adds the Win64 when necessary.
BTW, that trick with the script variables is neat. Didn't know that.

[xpol]

OK. Thank you very much @ignacio !

And I think the x64 flag should applied only once like my setup here:

https://github.com/xpol/lua-rapidjson/blob/master/.scripts/install.bat#L166-L176

Which I does not repeat my self 😄 .

Thank you for your pull request.
You are a great warm ❤️ man to work with!

[ignacio]

😄 Thanks!