Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editorial rewrite of p:declare-step #520

Merged
merged 1 commit into from
Sep 3, 2018
Merged

Editorial rewrite of p:declare-step #520

merged 1 commit into from
Sep 3, 2018

Conversation

ndw
Copy link
Contributor

@ndw ndw commented Sep 1, 2018

This is a rewrite of p:declare-step. It isn't supposed to change any of the semantics, but I hope that it clarifies things enough to close #513

xatapult
xatapult approved these changes Sep 3, 2018
View reviewed changes
Copy link
Contributor

@xatapult xatapult left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this, its getting better! I'll check whether it answers all my questions for #513. If not we can talk about it in Leipig

@ndw ndw merged commit ecf102c into xproc:master Sep 3, 2018
@ndw ndw deleted the iss-513 branch September 3, 2018 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xatapult xatapult xatapult approved these changes

@gimsieke gimsieke Awaiting requested review from gimsieke

@xml-project xml-project Awaiting requested review from xml-project

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Is more clarification needed around p:declare-step/p:library/p:variable?
2 participants
@ndw @xatapult