Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Say something about preservation of document properties when p:with-input/@select is used #138

Closed
gimsieke opened this issue Jun 16, 2019 · 3 comments

Comments

Projects
None yet
3 participants
@gimsieke
Copy link
Contributor

commented Jun 16, 2019

As I commented here a bit off-topic, if a pipeline author uses p:with-input/@select, the input document’s content-type, serialization and maybe base-uri properties might not be preservable even if the step says it will preserve all document properties.

Consider this:

<p:identity name="text">
  <p:with-input port="source">
    <p:inline>&lt;doc/></p:inline>
  </p:with-input>
</p:identity>
<!-- → Text document -->
<p:identity name="parse">
  <p:with-input port="source" select="parse-xml-fragment(/)">
</p:identity>
<!-- → XML document -->

Likewise, p:identity can turn an XML document into a text document using an appropriate p:with-input/@select.

This is not limited to p:identity. So I don’t think we can say for any step that it will preserve all document properties under all circumstances.

Should we say something about it in the steps spec introduction, after the bullet list below “Some aspects of documents are generally unchanged by steps:”?

@xml-project

This comment has been minimized.

Copy link
Contributor

commented Jun 16, 2019

👍

@ndw

This comment has been minimized.

Copy link
Collaborator

commented Jun 20, 2019

Consensus: we need to clarify content-type, base-uri, serialization, etc.

@ndw ndw self-assigned this Jun 20, 2019

ndw added a commit that referenced this issue Jun 22, 2019

Merge pull request #142 from ndw/iss-138
Markup errors and a fix for #138
@ndw

This comment has been minimized.

Copy link
Collaborator

commented Jun 22, 2019

Closed by #142

@ndw ndw closed this Jun 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.