New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide defaults for manifest and archive ports of p:archive? #239
Comments
My first reaction to this is pretty negative. I think it's going to be very confusing. If we provide a default binding, it will only apply if there isn't a default binding. So lots of the time, you'll get whatever happens to be on the DRP even if we specify a default binding. When that isn't appropriate, you'll still have to make the binding explicit. Or am I misunderstanding something? |
I don't quite get you I'm afraid, I do not understand what this has to do with the DRP. Here is what I mean: When you invoke <p:archive>
<p:with-input port="archive">
<p:empty/>
</p:with-input>
<p:with-input port="manifest">
<p:empty/>
</p:with-input>
</p:archive> Especially for the So why not just define the |
Because I think we understand the semantics differently. Consider:
The default bindings for |
@ndw wrote:
Would you mind to explain this please, because I do not get it. Ports |
Can't we say that unconnected non-primary ports will always connect to p:empty if no explicit or default connection is given? (If sequence=false, p:empty will cause a dynamic error, but this is Ok). |
Don‘t you think that is to wide a solution because it would apply to every user-defined step ever written. I would tend to Eriks suggestion to do this step wise. |
I think I misunderstood, sorry. I don't know why I keep forgetting that non-primary input ports aren't connected to the DRP by default. (I think that's so confusing, I guess that's why I keep forgetting.) So, yes, I guess we could make those inputs I do not have an informed opinion about whether or not that is a good idea at the moment. |
I agree with @xml-project that defaulting a So shall I change p:archive to bind these ports |
👍 I am not sure whether we have any other step in the standard or optional libraries with non-primary sequence ports. Binding them to p:empty by default might be an option too. |
Consensus or discuss in Cologne? |
FWIW, For at least Given that we've already accepted the semantics for secondary input ports with defaults, I'm not going to object to making the secondary ports on (As to Erik's earlier question about whether or not the spec formatter will do the right thing with the tableaux, I'll fix it if it doesn't.) |
Consensus to make the secondary ports (only) on |
I tried locally and a |
#239 provide defaults for non-primary input ports
The way the
p:archive
step is defined now means you always have to provide connections for themanifest
andarchive
input ports, even when you don't need them (which happens, quite often I think, especially thearchive
port). So you'll have to bind them top:empty
now.Shall we therefore provide these ports with a default
p:empty
connection?One problem (probably) (this one is for @ndw): Can the spec formatting pipeline handle default connections on input ports in a step specification?
The text was updated successfully, but these errors were encountered: