Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/leading slash params #40

Merged
merged 3 commits into from
Aug 31, 2018
Merged

Feature/leading slash params #40

merged 3 commits into from
Aug 31, 2018

Conversation

xqms
Copy link
Owner

@xqms xqms commented Aug 30, 2018

Discovered that roslaunch ignores leading slashes in <param> tags - but only when inside a node!

<launch>
        <param name="~private" value="test" />

        <group ns="group_ns">
                <param name="relative" value="test" />
                <param name="/group_ns_absolute" value="test" />
        </group>

        <node name="joy" pkg="joy" type="joy_node">
                <param name="relative" value="test" />
                <param name="/joy_absolute" value="test" />
        </node>
</launch>

Here, roslaunch will create /group_ns_absolute but /joy/joy_absolute - go figure.

This PR creates a unit test assertion for that case and creates a special in-node mode for parsing params.

@xqms xqms mentioned this pull request Aug 30, 2018
@xqms
Copy link
Owner Author

xqms commented Aug 30, 2018

Added a warning message if this occurs - as I feel it can be quite confusing.

@xqms
Copy link
Owner Author

xqms commented Aug 31, 2018

@ros-pull-request-builder retest this please

@xqms xqms merged commit 1bd8a4b into master Aug 31, 2018
@xqms xqms deleted the feature/leading_slash_params branch August 31, 2018 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant