launch_config: respect ROS_NAMESPACE variable

[xqms]

This allows nested configurations like the one mentioned in #46.

[romainreignier]

I have tested it in my workspace and it works like with roslaunch.

So, thank you very much, with these two issues resolved, I can now completely switch to rosmon and I my nested launch is now faster to be started.

[xqms]

Thanks!

I'll do a binary release as soon as #49 is fixed as well and things have settled for a bit :-)

[xqms]

@ros-pull-request-builder retest this please

[romainreignier]

I'll do a binary release as soon as #49 is fixed as well and things have settled for a bit :-)

I understand you want to wait a bit. But it would be nice to get these fixes released before this sync: https://discourse.ros.org/t/preparing-for-melodic-sync-2018-09-21/6101

[xqms]

I understand you want to wait a bit. But it would be nice to get these fixes released before this sync: https://discourse.ros.org/t/preparing-for-melodic-sync-2018-09-21/6101

Good point. I'll try to meet that deadline.

[xqms]

PR for rosdistro is open: ros/rosdistro#19150
Let's see if they still take it ;-)

[romainreignier]

Ah great!
Another improvement I was thinking is to create a separate package for the rqt plugin to avoid having to install gui stuff on an embedded computer.

[xqms]

Another improvement I was thinking is to create a separate package for the rqt plugin to avoid having to install gui stuff on an embedded computer.

Sounds like a good idea. I think I'd hold that for a 1.1 release, since this would be a breaking change (people with ros-*-rosmon installed suddenly don't have the GUI anymore).

Would you mind creating a separate ticket for this?