Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partial match warnings #87

Closed
DavisVaughan opened this issue Dec 7, 2020 · 3 comments
Closed

Partial match warnings #87

DavisVaughan opened this issue Dec 7, 2020 · 3 comments
Labels
bug No, it's not a feature!

Comments

@DavisVaughan
Copy link

With options(warnPartialMatchDollar = TRUE), pROC throws some partial match warnings, which propagated up into yardstick and tune in tidymodels/tune#334

options(warnPartialMatchDollar = TRUE)
library(pROC)
data(aSAH)

# Basic example
roc(
  aSAH$outcome, 
  aSAH$s100b,
  levels=c("Good", "Poor")
)
#> Setting direction: controls < cases
#> Warning: partial match of 'se' to 'sensitivities'
#> Warning: partial match of 'sp' to 'specificities'
#> 
#> Call:
#> roc.default(response = aSAH$outcome, predictor = aSAH$s100b,     levels = c("Good", "Poor"))
#> 
#> Data: aSAH$s100b in 72 controls (aSAH$outcome Good) < 41 cases (aSAH$outcome Poor).
#> Area under the curve: 0.7314
@xrobin
Copy link
Owner

xrobin commented Dec 7, 2020

I wasn't aware of this option.
It should be easy to fix. I'll try to get that done asap.

xrobin added a commit that referenced this issue Dec 9, 2020
@xrobin
Copy link
Owner

xrobin commented Dec 9, 2020

This needed changes in a few more places than I was expecting, but it should be fixed on master now.
Hopefully I haven't introduced more bugs. Fortunately the lines are all covered by tests so we should be safe.

I need to release a fix before Jan 12 upon request by CRAN (#88). I'd just like to assess where issue #82 stands and if it can go together, so this will be released soon, probably over the holiday.

@xrobin
Copy link
Owner

xrobin commented Dec 29, 2020

pROC 1.17.0 is ready and verified with the fix. Unfortunately CRAN submissions are suspended until Jan 4 2021 so the release will be delayed (#89)

@xrobin xrobin closed this as completed Dec 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug No, it's not a feature!
Projects
None yet
Development

No branches or pull requests

2 participants