Adding the OverrideINIReader for SciTokens #1860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default INI reader will concat duplicate section+name settings with a '\n' separator. The new OverrideINIReader will simply take the last value in the INI configuration file.
|
Please, let me know when this is ready to test. |
abh3
approved these changes
Dec 13, 2022
|
I just merged it so you should be able to rebase your repo and test.
Alternatively, you can grab an RPM from the yum repo pointed to by the
XRootD web page.
…On Tue, 13 Dec 2022, Fabio Andrijauskas wrote:
Please, let me know when this is ready to test.
--
Reply to this email directly or view it on GitHub:
#1860 (comment)
You are receiving this because you are subscribed to this thread.
Message ID: ***@***.***>
|
brianhlin
added a commit
to brianhlin/topology
that referenced
this pull request
Dec 15, 2022
This commit consolidates sections for the https://osg-htc.org/ospool in the scitokens.conf generated by Topology so that caches will respect the OSPool issuer + multiple base paths. xrootd-scitokens has multiple problems with duplicate issuers in its config (both the section name and the attribute name). 1. Duplicate `[Issuer ]` sections currently yield malformed values for attributes that are specified across these duplicate sections (values are `\n` separated). This is addressed but not yet released by choosing the last value for the duplicated section + attribute: - xrootd/xrootd#1860 - xrootd/xrootd#1862 2. Even with the fix for (1), this will result in only the last value of the duplicate sections being respected, which could cause transfers for end users to fail So to work around all that, we hack this all into a single namespace entry, which is fine since we don't use X.509 credentials and Path is only used for namespaces that respect X.509.
brianhlin
added a commit
to brianhlin/topology
that referenced
this pull request
Dec 15, 2022
This commit consolidates sections for the https://osg-htc.org/ospool in the scitokens.conf generated by Topology so that caches will respect the OSPool issuer + multiple base paths. xrootd-scitokens has multiple problems with duplicate issuers in its config (both the section name and the attribute name). 1. Duplicate `[Issuer ]` sections currently yield malformed values for attributes that are specified across these duplicate sections (values are merged and `\n` separated). This is addressed by choosing the last value for the duplicated section + attribute: - xrootd/xrootd#1860 - xrootd/xrootd#1862 These changes have not yet been released. 2. Even with the fix for (1), this will result in only the last value of the duplicate sections being respected, which could cause transfers for end users to fail So to work around all that, we hack this all into a single namespace entry, which is fine since we don't use X.509 credentials and Path is only used for namespaces that respect X.509.
brianhlin
added a commit
to brianhlin/topology
that referenced
this pull request
Dec 15, 2022
This commit consolidates sections for the https://osg-htc.org/ospool in the scitokens.conf generated by Topology so that caches will respect the OSPool issuer + multiple base paths. xrootd-scitokens has multiple problems with duplicate issuers in its config (both the section name and the attribute name). 1. Duplicate `[Issuer ]` sections currently yield malformed values for attributes that are specified across these duplicate sections (values are merged and `\n` separated). This is addressed by choosing the last value for the duplicated section + attribute: - xrootd/xrootd#1860 - xrootd/xrootd#1862 These changes have not yet been released. 2. Even with the fix for (1), this will result in only the last value of the duplicate sections being respected, which could cause transfers for end users to fail So to work around all that, we hack this all into a single namespace entry, which is fine since we don't use X.509 credentials and Path is only used for namespaces that respect X.509.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default INI reader will concat duplicate section+name settings with a '\n' separator. The new OverrideINIReader will simply take the last value in the INI configuration file.
For example:
Will result in a configuration with
base_pathset to/icecube/path2Replaces #1859