XrdTls: XrdTlsTempCA - CRLs containing critical extensions are inserted at the end of the bundled CRL file

[ccaffy]

Solves issue #2065

[abh3]

Somewhat minor issue and a suggestion to carry through the needed change to another part of the code. I was wondering why we are playing so many games with fdopen(), Would a single open stream suffice for this? I'm not asking to change it just curious why this is necessary.

[abh3]

Thanks Cedric!

…

On Tue, 22 Aug 2023, ccaffy wrote: @ccaffy commented on this pull request. > @@ -217,6 +234,26 @@ bool CRLSet::atLeastOneValidCRLFound() const { return m_atLeastOneValidCRLFound; } +bool CRLSet::processCRLWithCriticalExt() { + // Don't open the output file if not necessary + if(!m_crls_critical_extension.empty()) { + file_smart_ptr outputfp(fdopen(dup(m_output_fd), "w"), &fclose); I actually did it as it did not take a lot of time. I will submit a different PR once this one has been approved and merged to master -- Reply to this email directly or view it on GitHub: #2073 (comment) You are receiving this because you were mentioned. Message ID: ***@***.***>

[amadio]

@ccaffy I guess this is ready to merge, right?

[ccaffy]

@ccaffy I guess this is ready to merge, right?

Yes let's gooo !!!

[xrootd-dev]

Hi Cedric, Ah, don't forget with the follow-up pull request! Andy

…

On Tue, 22 Aug 2023, ccaffy wrote: > @ccaffy I guess this is ready to merge, right? Yes let's gooo !!! -- Reply to this email directly or view it on GitHub: #2073 (comment) You are receiving this because you are subscribed to this thread. Message ID: ***@***.***> ######################################################################## Use REPLY-ALL to reply to list To unsubscribe from the XROOTD-DEV list, click the following link: https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1