XrdTls: XrdTlsTempCA - Refactored CASet and CRLSet to open the output file only once before the processing #2075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… file only once before the processing
abh3
reviewed
Aug 23, 2023
It's just using RAII to open the file in the constructor and close it when the object is destroyed. I tested it and got no issue. Used |
|
Thanks for confirming that :-) |
abh3
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is coming from the PR #2073.
The Maintenance thread creates bundle CA and CRL files. Before this modification, the output files created by the maintenance were open and closed for each CA and CRL read. It is not the case anymore. There is only one open at the beginning of the processing and one close at the end.