Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XrdTls: XrdTlsTempCA - CRLs containing critical extensions are inserted at the end of the bundled CRL file #2073

Merged
merged 2 commits into from
Aug 23, 2023
Merged

XrdTls: XrdTlsTempCA - CRLs containing critical extensions are inserted at the end of the bundled CRL file #2073

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2df0061
XrdTls: XrdTlsTempCA - CRLs containing critical extensions are insert…
ccaffy Aug 21, 2023
fca07e4
XrdTls: XrdTlsTempCA - Replaced dup() by XrdSysFD_Dup() in output fil…
ccaffy Aug 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/XrdTls/XrdTlsTempCA.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@ class CRLSet {
bool
CRLSet::processFile(file_smart_ptr &fp, const std::string &fname)
{
file_smart_ptr outputfp(fdopen(dup(m_output_fd), "w"), &fclose);
file_smart_ptr outputfp(fdopen(XrdSysFD_Dup(m_output_fd), "w"), &fclose);
if (!outputfp.get()) {
m_log.Emsg("CRLSet", "Failed to reopen file for output", fname.c_str());
return false;
Expand Down Expand Up @@ -237,7 +237,7 @@ bool CRLSet::atLeastOneValidCRLFound() const {
bool CRLSet::processCRLWithCriticalExt() {
// Don't open the output file if not necessary
if(!m_crls_critical_extension.empty()) {
file_smart_ptr outputfp(fdopen(dup(m_output_fd), "w"), &fclose);
file_smart_ptr outputfp(fdopen(XrdSysFD_Dup(m_output_fd), "w"), &fclose);
if (!outputfp.get()) {
m_log.Emsg("CRLSet", "Failed to reopen file for output critical CRLs with critical extension");
return false;
Expand Down