Merge branch 'devel'

xsawyerx · Apr 5, 2012 · 3790b0f · 3790b0f
2 parents 965c147 + 47d2491
commit 3790b0f
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/dist.ini b/dist.ini
@@ -20,3 +20,4 @@ skip = ^t::lib::Functions$
 [ReadmeFromPod]
 [CheckChangeLog]
 [PkgVersion]
+[Repository]
diff --git a/lib/MetaCPAN/API.pm b/lib/MetaCPAN/API.pm
@@ -118,7 +118,9 @@ sub _build_extra_params {
         or croak 'Incorrect number of params, must be key/value';
 
     my %extra = @_;
-    my $extra = join '&', map { "$_=" . uri_escape($extra{$_}) } keys %extra;
+    my $extra = join '&', map {
+        "$_=" . uri_escape( $extra{$_} )
+    } sort keys %extra;
 
     return $extra;
 }

diff --git a/t/_build_extra_params.t b/t/_build_extra_params.t
@@ -31,14 +31,14 @@ is(
 # regular
 is(
     $mcpan->_build_extra_params( param1 => 'one', param2 => 'two' ),
-    'param2=two&param1=one',
+    'param1=one&param2=two',
     'Basic params',
 );
 
 # throw some symbols in there
 is(
     $mcpan->_build_extra_params( param1 => 'one', param2 => 'two space' ),
-    'param2=two%20space&param1=one',
+    'param1=one&param2=two%20space',
     'Escaping HTML in params',
 );