XEP-0047: fix incorrect max sequence number #1008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the text said that the max sequence number was 65535 (max unsigned 16 bit integer), but also said this was (1<<15)-1, which is actually max signed 16 bit integer or 32767.
horazont
added
the
Needs Council
|
I'd like to note that the schema also declares 'seq' to be of type xs:unsignedShort, which is a 16-bit unsigned integer. All in all, this is just an editorial change. |
horazont
added
Needs Version Block
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the text said that the max sequence number was 65535 (max
unsigned 16 bit integer), but also said this was (1<<15)-1, which is
actually max signed 16 bit integer or 32767.
This spec is final and therefore will need council review but per XEP-0001 can still be modified in small ways. I think this fits within the scope of "backwards compatible" modifications since it's effectively just a typo fix.