Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XEP-0373: Fix node name of secret key node #669

Merged
merged 1 commit into from
Jul 30, 2018
Merged

XEP-0373: Fix node name of secret key node #669

merged 1 commit into from
Jul 30, 2018

Conversation

vanitasvitae
Copy link
Contributor

Fix the name of the secret key node to follow the same pattern as the other node names.
This was originally part of #644 but I moved the change over here to allow #644 to get merged faster.

@vanitasvitae vanitasvitae mentioned this pull request Jun 22, 2018
Merged
@vanitasvitae vanitasvitae changed the title Fix node name of secret key node XEP-0373: Fix node name of secret key node Jun 22, 2018
@horazont horazont added the Needs Author The XEP is experimental and the PR was not made by the author. The author needs to acknowledge it. label Jul 5, 2018
@horazont horazont requested a review from Flowdalic July 5, 2018 13:59
@horazont horazont self-assigned this Jul 5, 2018
@horazont horazont added Ready To Merge No acknowledgements of other parties are needed anymore. There may be changes to do at merge time. Needs Version Block The change requires a version block, and this is to be done by Editors at merge time. and removed Needs Author The XEP is experimental and the PR was not made by the author. The author needs to acknowledge it. labels Jul 30, 2018
@horazont horazont merged commit 563b32b into xsf:master Jul 30, 2018
@vanitasvitae vanitasvitae mentioned this pull request Jul 30, 2018
Merged
@vanitasvitae vanitasvitae deleted the oxSecretNamespace branch July 30, 2018 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Flowdalic Flowdalic Flowdalic approved these changes

Assignees

@horazont horazont

Labels
Needs Version Block The change requires a version block, and this is to be done by Editors at merge time. Ready To Merge No acknowledgements of other parties are needed anymore. There may be changes to do at merge time.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vanitasvitae @Flowdalic @horazont