Skip to content

/ xeps

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XEP-0373: Add pubsub example #644

Merged
merged 1 commit into from Jul 5, 2018
Merged

XEP-0373: Add pubsub example #644

merged 1 commit into from Jul 5, 2018

Conversation

@vanitasvitae
Copy link
Contributor

@vanitasvitae vanitasvitae commented May 22, 2018

This PR adds an example about how the metadata node is being fetched.
It also fixes a small typo in one of the anchors.
@vanitasvitae
Add example, fix typo
Verified
This commit was signed with the committer’s verified signature.
vanitasvitae Paul Schaub
GPG key ID: 62BEE9264BF17311 Learn about signing commits
Loading status checks…
19b8d61
@vanitasvitae
Copy link
Contributor Author

@vanitasvitae vanitasvitae commented May 23, 2018

8c752ba is probably a breaking change.
@horazont
Copy link
Contributor

@horazont horazont commented May 24, 2018

@vanitasvitae Indeed, 8c752ba is breaking. Why did you include it in this PR? What is the rationale?
@horazont horazont requested a review from Flowdalic May 24, 2018
@horazont
Copy link
Contributor

@horazont horazont commented May 24, 2018

@Flowdalic please look at this
@vanitasvitae
Copy link
Contributor Author

@vanitasvitae vanitasvitae commented May 24, 2018

Why did you include it in this PR? What is the rationale?

Basically it was triggering my OCD 😉. Should I maybe exclude this change for now, so that it can be included in a later (breaking) change?
@vanitasvitae vanitasvitae force-pushed the vanitasvitae:oxfix branch from 8c752ba to 19b8d61 Jun 22, 2018
@vanitasvitae vanitasvitae mentioned this pull request Jun 22, 2018
Merged
@vanitasvitae
Copy link
Contributor Author

@vanitasvitae vanitasvitae commented Jun 22, 2018

I split this PR and moved the breaking change (8c752ba) to #669
@Flowdalic
Flowdalic approved these changes Jun 27, 2018
View changes
@horazont horazont self-assigned this Jul 5, 2018
@horazont horazont merged commit 19b8d61 into xsf:master Jul 5, 2018
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Flowdalic Flowdalic

Assignees

@horazont horazont

Labels
Needs Version Block Ready To Merge
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@vanitasvitae @horazont @Flowdalic @jcbrand