Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XEP-0373: Add pubsub example #644

Merged
merged 1 commit into from
Jul 5, 2018
Merged

XEP-0373: Add pubsub example #644

merged 1 commit into from
Jul 5, 2018

Conversation

vanitasvitae
Copy link
Contributor

This PR adds an example about how the metadata node is being fetched.
It also fixes a small typo in one of the anchors.

@vanitasvitae
Copy link
Contributor Author

8c752ba is probably a breaking change.

@horazont
Copy link
Contributor

@vanitasvitae Indeed, 8c752ba is breaking. Why did you include it in this PR? What is the rationale?

@horazont horazont added the Needs Author The XEP is experimental and the PR was not made by the author. The author needs to acknowledge it. label May 24, 2018
@horazont horazont requested a review from Flowdalic May 24, 2018 07:12
@horazont
Copy link
Contributor

@Flowdalic please look at this

@horazont horazont added the Needs Version Block The change requires a version block, and this is to be done by Editors at merge time. label May 24, 2018
@vanitasvitae
Copy link
Contributor Author

Why did you include it in this PR? What is the rationale?

Basically it was triggering my OCD 😉. Should I maybe exclude this change for now, so that it can be included in a later (breaking) change?

@vanitasvitae vanitasvitae mentioned this pull request Jun 22, 2018
Merged
@vanitasvitae
Copy link
Contributor Author

I split this PR and moved the breaking change (8c752ba) to #669

@jcbrand jcbrand removed the Needs Version Block The change requires a version block, and this is to be done by Editors at merge time. label Jul 3, 2018
@horazont horazont added Ready To Merge No acknowledgements of other parties are needed anymore. There may be changes to do at merge time. Needs Version Block The change requires a version block, and this is to be done by Editors at merge time. and removed Needs Author The XEP is experimental and the PR was not made by the author. The author needs to acknowledge it. labels Jul 5, 2018
@horazont horazont self-assigned this Jul 5, 2018
@horazont horazont merged commit 19b8d61 into xsf:master Jul 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Flowdalic Flowdalic Flowdalic approved these changes

Assignees

@horazont horazont

Labels
Needs Version Block The change requires a version block, and this is to be done by Editors at merge time. Ready To Merge No acknowledgements of other parties are needed anymore. There may be changes to do at merge time.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vanitasvitae @horazont @Flowdalic @jcbrand