New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XEP-0373: Add pubsub example #644

Merged
merged 1 commit into from Jul 5, 2018

Conversation

Projects
None yet
4 participants
@vanitasvitae
Contributor

vanitasvitae commented May 22, 2018

This PR adds an example about how the metadata node is being fetched.
It also fixes a small typo in one of the anchors.

@vanitasvitae

This comment has been minimized.

Contributor

vanitasvitae commented May 23, 2018

8c752ba is probably a breaking change.

@horazont

This comment has been minimized.

Contributor

horazont commented May 24, 2018

@vanitasvitae Indeed, 8c752ba is breaking. Why did you include it in this PR? What is the rationale?

@horazont horazont requested a review from Flowdalic May 24, 2018

@horazont

This comment has been minimized.

Contributor

horazont commented May 24, 2018

@Flowdalic please look at this

@vanitasvitae

This comment has been minimized.

Contributor

vanitasvitae commented May 24, 2018

Why did you include it in this PR? What is the rationale?

Basically it was triggering my OCD 😉. Should I maybe exclude this change for now, so that it can be included in a later (breaking) change?

@vanitasvitae

This comment has been minimized.

Contributor

vanitasvitae commented Jun 22, 2018

I split this PR and moved the breaking change (8c752ba) to #669

@horazont horazont self-assigned this Jul 5, 2018

@horazont horazont merged commit 19b8d61 into xsf:master Jul 5, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment