New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve BaseX server test for Windows #580

Closed

AirQuick opened this issue Jun 25, 2019 · 0 comments · Fixed by #587

Assignees

Labels

test

Milestone

Member

AirQuick commented Jun 25, 2019

BaseX server test for Windows has some room for improvement:

BaseX batch files are run within the current batch file context. They can pollute the environment. They should be run in a child process.

xspec/test/win-bats/collection.xml

Lines 353 to 354 in e7c1bb1

rem Start BaseX server

call "%BASEX_HOME%\bin\basexhttp.bat" -S

xspec/test/win-bats/collection.xml

Lines 375 to 376 in e7c1bb1

rem Stop BaseX server

call "%BASEX_HOME%\bin\basexhttpstop.bat"
A slash should be replaced with a backslash, though the slash seems to be working.

xspec/test/win-bats/collection.xml

Lines 356 to 357 in e7c1bb1

rem Output file

set "EXPECTED_REPORT=%WORK_DIR%/xquery-tutorial-result.html"

AirQuick added the test label

AirQuick self-assigned this

AirQuick mentioned this issue

Improve BaseX server test for Windows #587

Merged

AirQuick added this to the v1.5.0 milestone

AirQuick closed this as completed in #587

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment