Remove deprecated no-op setInterruptSafety() call #52
Conversation
|
This will not be easy. It was added as a fix for 66b896e to solve https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=1236722 |
|
OK, now I realize this PR was a bit rushed on my side, I somehow mixed up the chronology of the commits linked above and thought the Python binding had been no-op for a long time. Whereas, it really was only deprecated and made no-op in 4.18 which came out last year. 🤦 Apologies for that. That said, the functionality itself might indeed be redundant now that we no longer use BDB, but depending on your release model, you may want to keep the code compatible with older RPM versions, too. In that case, we could perhaps apply this patch downstream only (in Rawhide). Anyway, let's revisit when you're back. |
This function became a no-op [1] in RPM 4.18 where it was also deprecated [2], and is completely gone in RPM 4.19 [3]. Adjust the version check accordingly. Note that the function itself seems to have no effect in RPM 4.16 already where the Berkeley DB backend was swapped for sqlite, but don't risk breaking stuff here and just keep the call in place for those older RPM versions. More info here: [1] https://github.com/rpm-software-management/rpm/commit/ baeb71141744bb0db6bd72c580bfaf929b7b4fb2 [2] rpm-software-management/rpm#1994 [3] rpm-software-management/rpm#1992
|
I've updated the PR with a backward compatible version of the same, hopefully this is now better. Whether or not there's a regression in terms of 66b896e with RPM 4.18 I'm not sure but if so, that has to be fixed separately. This PR is just to make rpmconf work with RPM 4.19 the same way as it did with 4.18. IOW, to adapt rpmconf to the deprecation in 4.18. |
|
Closing in favour of #53 |
This function no longer has any effect in RPM since the removal of the Berkeley DB backend in RPM 4.16. The Python binding has been deprecated for a while now, and is completely gone in RPM 4.19, so let's move with the times.
More info here:
rpm-software-management/rpm#1946
rpm-software-management/rpm#1992
rpm-software-management/rpm#1994