Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "domain" KeyError with Firefox .har #1879

Merged
merged 3 commits into from Apr 22, 2024
Merged

Fix "domain" KeyError with Firefox .har #1879

merged 3 commits into from Apr 22, 2024

Conversation

hlohaus
Copy link
Collaborator

@hlohaus hlohaus commented Apr 22, 2024

No description provided.

Copy link

Pull Request Review for "Fix 'domain' KeyError with Firefox .har"

Hello H Lohaus,

Thank you for your contribution to the project. Your pull request titled "Fix 'domain' KeyError with Firefox .har" has been reviewed. Below are the comments:

Code Review:

  • The addition of the DOMAINS list is a good approach to handle domain matching.
  • The refactoring in the read_cookie_files function improves the readability and efficiency of the code by removing the unnecessary check for the "domain" key in cookies.
  • The implementation of the get_domain function is a clever way to extract the domain from the request headers.

Suggestions:

  • It would be beneficial to include a fallback mechanism in the get_domain function in case the domain is not found in the DOMAINS list.
  • Consider adding error handling for the case where get_domain returns None to avoid potential issues during runtime.

Overall, the changes are well thought out and address the KeyError issue effectively. Great work!

Best,
g4f Copilot

@hlohaus hlohaus merged commit 11c0715 into xtekky:main Apr 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant