Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix arange with integers #1361

Merged
merged 1 commit into from
Jan 21, 2019
Merged

Fix arange with integers #1361

merged 1 commit into from
Jan 21, 2019

Conversation

martinRenou
Copy link
Member

Before this fix:

xt::arange(0, 10, 3); // == {0, 3, 6}

After this fix:

xt::arange(0, 10, 3); // == {0, 3, 6, 9}

@SylvainCorlay
Copy link
Member

giphy 1

@martinRenou martinRenou changed the title Fix arange with integers WIP - Fix arange with integers Jan 21, 2019
@martinRenou martinRenou changed the title WIP - Fix arange with integers Fix arange with integers Jan 21, 2019
JohanMabille
JohanMabille requested changes Jan 21, 2019
View reviewed changes
include/xtensor/xbuilder.hpp Outdated Show resolved Hide resolved
include/xtensor/xbuilder.hpp Outdated Show resolved Hide resolved
@SylvainCorlay SylvainCorlay merged commit dbc3a37 into xtensor-stack:master Jan 21, 2019
@martinRenou martinRenou deleted the fix_arange branch January 21, 2019 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohanMabille JohanMabille JohanMabille approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@martinRenou @SylvainCorlay @JohanMabille