-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix memory leak of npy_file's move assignment #2719
Conversation
7bd6862
to
556177e
Compare
Thanks! Sorry for not addressing this sooner. I'm not an expert on this part of the code, but I will try to help. Could you first rebase your PR on the current master in which the CI issues are fixed, such that we can take it from there? |
Also, could you add a test case with which we could have found this bug? |
This pr is stale because it has been open for 60 days with no activity. |
556177e
to
c5afecf
Compare
Done! |
This PR fix mem-leak of
|
This pr is stale because it has been open for 60 days with no activity. |
Could you add this to the tests? Thanks! |
This pr is stale because it has been open for 60 days with no activity. |
This issue was closed because it has been inactive for 14 days since being marked as stale. |
Checklist
Description
Fix memory leak when one npy_file move to another npy_file.