Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Selection doesn't always redraw when resizing the window (canvas renderer) #1963

Closed
Tyriar opened this issue Mar 8, 2019 · 2 comments · Fixed by #3938
Closed

Selection doesn't always redraw when resizing the window (canvas renderer) #1963

Tyriar opened this issue Mar 8, 2019 · 2 comments · Fixed by #3938
Assignees
@Tyriar
Labels
area/addon/canvas good first issue help wanted type/bug Something is misbehaving
Milestone
5.0.0

Comments

@Tyriar
Copy link
Member

Tyriar commented Mar 8, 2019

Repro:

  1. Make a selection
  2. Resize the window

Sometimes the selection will show, sometimes not.
@Tyriar Tyriar added type/bug Something is misbehaving area/renderer help wanted labels Mar 8, 2019
@Tyriar Tyriar mentioned this issue Mar 8, 2019
Closed
@Tyriar
Copy link
Member Author

Tyriar commented Mar 8, 2019

Selection is drawn here for the canvas renderer: https://github.com/xtermjs/xterm.js/blob/master/src/renderer/SelectionRenderLayer.ts

@khoitd1997
Copy link

I will tackle this one

@khoitd1997 khoitd1997 mentioned this issue Apr 17, 2019
Closed
@silamon silamon mentioned this issue Jun 20, 2021
Closed
Tyriar added a commit to Tyriar/xterm.js that referenced this issue Jul 25, 2022
@Tyriar
Redraw canvas renderer selection on resize
9159fc6 
Fixes xtermjs#1963
@Tyriar Tyriar mentioned this issue Jul 25, 2022
Merged
@Tyriar Tyriar added this to the 4.20.0 milestone Jul 25, 2022
@Tyriar Tyriar self-assigned this Jul 25, 2022
@Tyriar Tyriar modified the milestones: 4.20.0, 5.0.0 Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tyriar Tyriar

Labels
area/addon/canvas good first issue help wanted type/bug Something is misbehaving
Projects
None yet
Milestone
5.0.0
2 participants
@Tyriar @khoitd1997