Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove old event listeners #2029

Closed
Tyriar opened this issue Apr 28, 2019 · 0 comments · Fixed by #2211
Closed

Remove old event listeners #2029

Tyriar opened this issue Apr 28, 2019 · 0 comments · Fixed by #2211
Assignees
@Tyriar
Labels
area/api breaking-change Breaks API and requires a major version bump type/debt Technical debt that could slow us down in the long run
Milestone
4.0.0

Comments

@Tyriar
Copy link
Member

Tyriar commented Apr 28, 2019

Follow up for #1505 in v4
@Tyriar Tyriar added breaking-change Breaks API and requires a major version bump area/api labels Apr 28, 2019
@Tyriar Tyriar added this to the 4.0.0 milestone Apr 28, 2019
@Tyriar Tyriar self-assigned this Apr 28, 2019
@Tyriar Tyriar added the type/debt Technical debt that could slow us down in the long run label May 22, 2019
@Tyriar Tyriar mentioned this issue May 30, 2019
Closed
Tyriar added a commit to Tyriar/xterm.js that referenced this issue Jun 9, 2019
@Tyriar
Remove old event emitter
447fc4f 
Fixes xtermjs#2029
Tyriar added a commit to Tyriar/xterm.js that referenced this issue Jun 9, 2019
@Tyriar
Rename EventEmitter2 to EventEmitter
80ce33f 
Fixes xtermjs#2029
@Tyriar Tyriar mentioned this issue Jun 9, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tyriar Tyriar

Labels
area/api breaking-change Breaks API and requires a major version bump type/debt Technical debt that could slow us down in the long run
Projects
None yet
Milestone
4.0.0
Development

Successfully merging a pull request may close this issue.

Remove old event emitter, rename new one to EventEmitter Tyriar/xterm.js
1 participant
@Tyriar