Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace IEventEmitter in API with explicit handlers #1505

Closed
Tyriar opened this issue Jun 9, 2018 · 0 comments · Fixed by #2008
Closed

Replace IEventEmitter in API with explicit handlers #1505

Tyriar opened this issue Jun 9, 2018 · 0 comments · Fixed by #2008
Labels
area/api type/enhancement Features or improvements to existing features
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Jun 9, 2018

// Instead of this:
this._xterm.on('key', f);
// Do this:
this._xterm.onKey(f);

We could remove IEventEmitter from the API and just use that internally. This would prevent errors like:

this._xterm.on('ky', f);

And also make it harder to access private events.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api type/enhancement Features or improvements to existing features
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant