-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
emoji/unicode support mostly broken in windows #2693
Comments
Any plans to iterate on this issue? |
Just time is blocking it, I have too many more important things to look at so I doubt I would be able to get to it. This needs some investigation of what differs with emoji between native ptys and Conpty on Windows and to come up with a plan to support both. |
Emoji support for windows terminal looks backlogged since 2018 microsoft/terminal#190 |
Oh ok, so it's partially supported then. I thought I saw them advertising emoji support as one of the shiny things in WT 🤔 |
Last time I looked at it the problem was around line/screen refresh pattern used by conpty. The emojis itself came thought but got partially scrambled by wrong offsets of the refreshs (deleting parts of multibyte chars). |
Some of the emoji still doesn't show up. |
Quick update here: Windows Terminal's emoji layout & handling has improved a lot over the last couple of years and now seems to handle most emoji that I throw at it pretty well. If you find specific emoji that don't render correctly in Windows Terminal, please find/file an issue at https://github.com/microsoft/terminal/issues VSCode's terminal is a separate implementation built by @Tyriar & team using JavaScript (since VSCode is an Electron-based app) and needs a little work to make emoji work better. As Daniel points out above, "this needs some investigation" so could be a good candidate for someone with some time available to dig in and see if improvements can be made? |
Hi, I just opened another issue in microsoft/terminal that might be related, i'm not sure: microsoft/terminal#14084 |
Reminder issue to get the hands dirty to identify/fix unicode issues in windows, for some background see comments in #2568.
The text was updated successfully, but these errors were encountered: