Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Draw custom underscore glyph if it's determined it would be drawn outside of the cell #3423

Closed
Tyriar opened this issue Aug 19, 2021 · 1 comment · Fixed by #3426
Closed

Draw custom underscore glyph if it's determined it would be drawn outside of the cell #3423

Tyriar opened this issue Aug 19, 2021 · 1 comment · Fixed by #3426
Assignees
@Tyriar
Labels
area/addon/webgl type/enhancement Features or improvements to existing features
Milestone
4.14.0

Comments

@Tyriar
Copy link
Member

Tyriar commented Aug 19, 2021

VS Code issue: microsoft/vscode#130967

I have an idea on fixing this, perhaps we should measure the underscore character in particular and measure if it would get cut off from the line and if so we would draw it custom (this could even be rolled into the upcoming custom box drawing/block element glyph setting). This custom drawing could be maybe 1 pixel higher than the underline style such that links and underscore styles can still be differentiated from underscores.
@Tyriar Tyriar added type/enhancement Features or improvements to existing features area/renderer area/addon/webgl labels Aug 19, 2021
@Tyriar Tyriar added this to the 4.14.0 milestone Aug 19, 2021
@Tyriar Tyriar self-assigned this Aug 19, 2021
@Tyriar Tyriar mentioned this issue Aug 19, 2021
Closed
@Tyriar
Copy link
Member Author

Tyriar commented Aug 19, 2021

Alt approach: Shift the texture up instead of custom drawing to ensure it's always within the cell

Tyriar added a commit to Tyriar/xterm.js that referenced this issue Aug 19, 2021
@Tyriar
Ensure underscore is within cell bounds
53dbcba 
Fixes xtermjs#3423
@Tyriar Tyriar mentioned this issue Aug 19, 2021
Merged
@zmb3 zmb3 mentioned this issue Jul 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tyriar Tyriar

Labels
area/addon/webgl type/enhancement Features or improvements to existing features
Projects
None yet
Milestone
4.14.0
Development

Successfully merging a pull request may close this issue.

Ensure underscore is within cell bounds Tyriar/xterm.js
1 participant
@Tyriar