Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow multiple varying height rows to be allocated to the char atlas at once #3977

Closed
Tyriar opened this issue Jul 31, 2022 · 0 comments · Fixed by #3979
Closed

Allow multiple varying height rows to be allocated to the char atlas at once #3977

Tyriar opened this issue Jul 31, 2022 · 0 comments · Fixed by #3979
Assignees
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Jul 31, 2022

Since underlines are now rendered in the atlas we can get into this situation:

Screen Shot 2022-07-30 at 5 56 19 pm

While it is pretty unlikely for this to happen in practice, this is a change I'm wanted to do for a while. Basically allow multiple active rows to exist in the char atlas at once, in practice this should typically put all the short chars ~, -, _, etc. into that row and save a bunch of vertical space in the texture.

@Tyriar Tyriar added this to the 5.0.0 milestone Jul 31, 2022
@Tyriar Tyriar self-assigned this Jul 31, 2022
Tyriar added a commit to Tyriar/xterm.js that referenced this issue Jul 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant