Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing CSS file in npm package #414

Closed
blink1073 opened this issue Dec 15, 2016 · 7 comments
Closed

Missing CSS file in npm package #414

blink1073 opened this issue Dec 15, 2016 · 7 comments
Assignees

Comments

@blink1073
Copy link
Contributor

Current release (2.2.2) does not include the src/xterm.css file.

@blink1073
Copy link
Contributor Author

I am happy to submit a PR with a script that copies the file over before publishing: cf https://github.com/jupyterlab/jupyterlab/blob/bda6c803494a0e6ddf5df673749be5a9590bf719/scripts/copyfiles.js

@Tyriar
Copy link
Member

Tyriar commented Dec 15, 2016

The copy is meant to be done here https://github.com/sourcelair/xterm.js/blob/master/bin/build#L29, maybe it's not being published due to files in package.json?

@blink1073
Copy link
Contributor Author

@parisk
Copy link
Contributor

parisk commented Dec 15, 2016

On it.

@parisk
Copy link
Contributor

parisk commented Dec 15, 2016

@Tyriar and @blink1073 feel free to take a look at #416. I will merge ASAP.

parisk referenced this issue Dec 15, 2016
@parisk
Copy link
Contributor

parisk commented Dec 15, 2016

Should be fine with 2.2.3

@blink1073
Copy link
Contributor Author

The copy script still didn't do the trick, because the release has the CSS in the src/ folder but not the lib/ folder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants