Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebKit playwright test failure: minimumContrastRatio - should enforce half the contrast for dim cells #4769

Closed
Tyriar opened this issue Sep 8, 2023 · 1 comment · Fixed by #4777
Closed

WebKit playwright test failure: minimumContrastRatio - should enforce half the contrast for dim cells #4769

Tyriar opened this issue Sep 8, 2023 · 1 comment · Fixed by #4777
Assignees
@Tyriar
Labels
type/bug Something is misbehaving
Milestone
5.4.0

Comments

@Tyriar
Copy link
Member

Tyriar commented Sep 8, 2023

I haven't investigated why it's failing yet
@Tyriar Tyriar added help wanted type/bug Something is misbehaving labels Sep 8, 2023
@Tyriar Tyriar mentioned this issue Sep 8, 2023
Merged
@Tyriar
Copy link
Member Author

Tyriar commented Sep 9, 2023

It's a rounding difference between browsers

@Tyriar Tyriar added this to the 5.4.0 milestone Sep 9, 2023
@Tyriar Tyriar self-assigned this Sep 9, 2023
@Tyriar Tyriar removed the help wanted label Sep 9, 2023
Tyriar added a commit to Tyriar/xterm.js that referenced this issue Sep 9, 2023
@Tyriar
Fix MCR test on webkit, add pollForApproximate
1792eaf 
Fixes xtermjs#4769
@Tyriar Tyriar mentioned this issue Sep 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tyriar Tyriar

Labels
type/bug Something is misbehaving
Projects
None yet
Milestone
5.4.0
Development

Successfully merging a pull request may close this issue.

Fix MCR test on webkit, add pollForApproximate Tyriar/xterm.js
1 participant
@Tyriar