Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOM renderer playwright tests #4768

Merged
merged 15 commits into from Sep 8, 2023
Merged

DOM renderer playwright tests #4768

merged 15 commits into from Sep 8, 2023

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Sep 8, 2023

Fixes #4767


Summary:

  • Webgl api tests have been migrated to @playwright/test
  • A new script was added to run all tests, I tried to set up the core config to run both core and addon tests but couldn't figure it out. Anyway the new script is quite robust
  • Webgl tests have been made generic and are now shared between the new webgl test suite and the old webgl suite
  • Refined the method of checking pixel colors, this speeds things up quite a bit as each frame now only needs to be fetched once. This uses lunapaint/png-codec to decode the image on the node side.
  • Renderer tests now pass in webkit (there's a single skipped renderer test WebKit playwright test failure: minimumContrastRatio - should enforce half the contrast for dim cells #4769)
  • Improved diagnostics when running playwright tests with DEBUG=1

@Tyriar Tyriar added this to the 5.4.0 milestone Sep 8, 2023
@Tyriar Tyriar self-assigned this Sep 8, 2023
@Tyriar Tyriar marked this pull request as draft September 8, 2023 15:38
@Tyriar Tyriar marked this pull request as ready for review September 8, 2023 17:22
@Tyriar Tyriar merged commit 34933d2 into xtermjs:master Sep 8, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce DOM renderer (or renderer agnostic) playwright tests
1 participant