Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to @xterm org on npm #4859

Closed
4 tasks done
Tyriar opened this issue Nov 1, 2023 · 6 comments
Closed
4 tasks done

Migrate to @xterm org on npm #4859

Tyriar opened this issue Nov 1, 2023 · 6 comments
Assignees
Labels
area/build Regarding the build process
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Nov 1, 2023

In order to prevent problems like #4857 in the future let's move to scoped packages on npm. I don't consider this a breaking change as it needs a manual action to update anyway.

Plan:

  • Start publishing beta builds to @xterm/xterm, @xterm/addon-search, etc.
  • Publish 5.4 to new scope
  • Deprecate old packages with a message redirecting users to the new package name
  • update all docs snippets including paths in <script> elements here and on xtermjs.org (added by @jerch)
@Tyriar Tyriar added the area/build Regarding the build process label Nov 1, 2023
@Tyriar Tyriar added this to the 5.4.0 milestone Nov 1, 2023
@Tyriar Tyriar self-assigned this Nov 1, 2023
This was referenced Nov 1, 2023
Closed
Tyriar added a commit to Tyriar/xterm.js that referenced this issue Nov 1, 2023
Tyriar added a commit to microsoft/vscode that referenced this issue Nov 1, 2023
xterm-addon-image is excluded currently as there are some publishing
issues.

See xtermjs/xterm.js#4859
Tyriar added a commit to microsoft/vscode that referenced this issue Nov 1, 2023
xterm-addon-image is excluded currently as there are some publishing
issues.

See xtermjs/xterm.js#4859
@jerch
Copy link
Member

jerch commented Nov 3, 2023

@Tyriar Wow, that already created quite a refactoring noise. Thx for getting it fixed this quickly.

@Tyriar
Copy link
Member Author

Tyriar commented Nov 3, 2023

@jerch np, it was our tech debt week so conveniently timed 🙂 ended up being a pretty chunky VS Code PR too microsoft/vscode#197167

@davidfiala
Copy link
Contributor

Would you please clarify how you are publishing the 5.4.0 betas during this transitional moment?

For example:

For example: the timestamps indicate a more recent beta 14 publish than one numbered beta 37.

I could have figured it out myself, but I didn't see git tags on the betas, so I'm not sure if there is an easy way for an outsider to track which hash each beta corresponds to. Let me know if I missed something.

Thanks!

@Tyriar
Copy link
Member Author

Tyriar commented Nov 20, 2023

@davidfiala @xterm/xterm@beta is the new latest after this change went in. There isn't a stable yet but it will be 5.4.0 when it happens. The only way to check what commit the builds are based on currently it to look at the action log https://github.com/xtermjs/xterm.js/actions/workflows/release.yml

@jerch
Copy link
Member

jerch commented Nov 20, 2023

What might be confusing here, is the fact that the 14 is actually newer than the 37. Have not looked up the publish script - my guess is, that the script simply started over for the @xterm/xterm.

Which means - anything in @xterm/xterm in newer than the last beta release under just xterm.

@Tyriar
Copy link
Member Author

Tyriar commented Mar 1, 2024

I deprecated xterm and xterm-headless. I don't think I can give it a custom message unfortunately

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build Regarding the build process
Projects
None yet
Development

No branches or pull requests

3 participants