-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Have addons implement their API at compile time #4847
Conversation
ok . All addons have been added. edit: |
I'm trying to fix the conflicts now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just what I was after 🤌
@tisilent Wow - thats a really interesting idea to solve the issue. ❤️ On a sidenote - that even solves another (non?) issue: its not possible anymore to accidentally import the addon into itself due to the path masking rule, whoever would have wanted that in the first place 😺 I still wonder - was there a specific reason to do it via a path rule, and not by directly importing the types from the d.ts files? |
@jerch Without specifying path rules, TS compile may encounter problems. 😅 |
When the '. d. ts' file uses the import. declared |
Ah ok, glad you found a way around. I kinda never fully understood the |
fix #4828
clearTextureAtlas
found in canvas addonerror TS2307: Cannot find module
will happen and the reason cannot be found 💫