Additional alt and control sequences #1231

saamalik · 2018-01-22T00:48:23Z

Add punctuation alt sequences (both shift/non-shift versions)
Add support for ctrl+alt sequences

Follow up to #1225.
Fixes #1267

Sample bash key sequences to try:

ctrl+alt+y: yank first argument from previous command
alt+.: yank last argument previous command

* Add punctuation alt sequences * Add support for ctrl+alt sequences

saamalik · 2018-01-22T00:54:04Z

src/Terminal.ts

          } else if (ev.keyCode >= 48 && ev.keyCode <= 57) {
            result.key = C0.ESC + (ev.keyCode - 48);
+          } else {
+            const t = (p,s) => !ev.shiftKey ? p : s;
+            switch (ev.keyCode) {


BTW another possible implementation is having a map structure, e.g:

{ 186: [';', ':'], 187: ['=', '+'], 188: [',', '<'], ..... }

And then essentially just do a lookup in map to get actual code.

Let me know if you guys prefer the map instead and I can re-implement.

saamalik · 2018-01-22T00:58:01Z

src/Terminal.ts

          } else if (ev.keyCode >= 48 && ev.keyCode <= 57) {
            result.key = C0.ESC + (ev.keyCode - 48);
+          } else {
+            const t = (p, s) => !ev.shiftKey ? p : s;
+            switch (ev.keyCode) {


BTW another possible implementation is having a map structure, e.g:

{ 186: [';', ':'], 187: ['=', '+'], 188: [',', '<'], ..... }

And then essentially just do a lookup in map to get actual code.

Let me know if you guys prefer the map instead and I can re-implement.

saamalik · 2018-01-23T19:30:18Z

@Tyriar what are your thoughts on this PR? I don't mind dropping the whole branch and starting afresh if you give me some high-level guidance/pointers.

Ideally we could solve the following two use-cases:

ctrl + alt + [a-z]: these are useful in bash (ctrl-alt-y) and also in VIM
alt + {special-char}: useful in bash (alt+.) and again in ViM.

For the alt+{special-char} implementation, I essentially mimicked what ITerm2 emits. If you don't like the giant switch (or the proposed map) implementation maybe we could reduce the list to just the known character sets; or maybe find ranges for which we could lookup key via basic artithmetic, e.g: ev.keyCode - 144--though the shift characters would need to be dropped.

Tyriar · 2018-01-25T19:39:23Z

Sorry about not getting to this, a few things:

👍 to the map (which should let you remove the t function)
Does ctrl+alt+[a-z] do anything at the moment?
I'm assuming alt+[special char] only works when macOptionIsMeta is true?
What's up with the tilde key? Can we do nothing there instead?
How does iTerm2/Terminal.app behave with these new keybindings?

saamalik · 2018-01-26T21:24:49Z

@Tyriar -- cool, will re-implement using the map and provide answers to your questions in a bit.

saamalik · 2018-01-27T01:05:07Z

Does ctrl+alt+[a-z] do anything at the moment?

Tried with both mcOptionIsMeta on and off, but the ctrl+alt+[a-z] sequences are completely ignored. Even with t.setOption('debug', true) there is nothing printed to the console.

alt+[special char] only works when macOptionIsMeta is true?

Yup, on Mac OSX both the alt+[special char] and alt+shift+[special char] only works when macOptionIsMeta; otherwise completely ignored.

Same with alt+[digit] (enabled on Win/Linux or when macOptionIsMeta). However, alt+shift+[digit] also outputs the same sequence as alt+[digit], which is incorrect. As part of the PR I'll also fix the alt+shift+[digit] to output the same sequence as iTerm/Terminal.app. With this fix, on bash pressing alt+shift+* will expand all matches on command-line. It'll bring the same sequences which are supported on iTerm/Terminal.app.

What's up with the tilde key? Can we do nothing there instead?

This tool shows the tilde as a DEADKEY; however iTerm2 outputs appropriate distinct sequences ^[` and ^[~ for alt+` and alt+shift+~, respectively. PR will add support for both sequences and be consistent with other keys.

How does iTerm2/Terminal.app behave with these new keybindings?

All of the new mappings are exactly mirroring the sequences emitted with iTerm2/Terminal.app. This was verified using the ctrl+v and entering the appropriate key sequence. There might be other keyboard sequences, but at least the ones captured in the PR will match iTerm2/Terminal.app and other terminals.

* Reimplemented reg + shift alt digits and characters using a map * Add test cases for digits

saamalik · 2018-01-27T02:46:51Z

@Tyriar this PR is ready for review. Keycode -> key mapping has been re-implemented using a map (actually an Object, but let me know if you prefer an actual Map even though syntax will look ugly with double, and triple square-brackets).

As I mentioned in the previous comment, all key -> key sequences introduced in this PR match exactly what iTerm2 emits. On bash, here are some of the mappings you can try (enable macOptionIsMeta if on OSX):

$ touch p1 p2 p3
$ echo a b c d
$ <ctrl+alt+y> # a
$ <alt+.> # d
$ ls p<alt+shift+/> #list glob-matching files
$ ls p<alt+shift+8> # insert glob-matching files as arguments
$ echo bad command do not run <alt+shift+3> # comment out command

Let me know if you have any questions or would like further changes. Thanks!

* Add mapping for backward slash * Fix mapping for single/double quote

saamalik · 2018-01-31T03:20:03Z

@Tyriar friendly ping. What are your thoughts on the PR?

Tyriar · 2018-01-31T19:08:21Z

@saamalik I like it, just might take some time to give it a full review/test. I don't expect many more changes needed to get it merged. I'm hoping to get it in for 3.1.0 😃

saamalik · 2018-02-01T20:18:12Z

@Tyriar btw let me know if you'd like me to squash all commits on top of origin/master.

Tyriar · 2018-02-02T02:33:03Z

@saamalik should be fine without that

saamalik · 2018-02-14T17:13:19Z

@Tyriar just another friendly ping to see if we could please get this merged-in?

Tyriar

Sorry about the delay, super busy working on terminal splitting for VS Code 😅

This looks good and also seems to work as advertised so I'll merge. Thanks a bunch for the PR!

saamalik · 2018-02-22T01:30:04Z

@Tyriar wohoo -- thanks!

Additional alt and control sequences

ec9f270

* Add punctuation alt sequences * Add support for ctrl+alt sequences

saamalik commented Jan 22, 2018

View reviewed changes

Cleaup whitespace

d62e4e2

saamalik commented Jan 22, 2018

View reviewed changes

saamalik added 2 commits January 22, 2018 12:53

Merge branch 'master' into ctrl-alt-sequences

bb8e065

Merge branch 'master' into ctrl-alt-sequences

e1c99b2

saamalik closed this Jan 23, 2018

saamalik reopened this Jan 23, 2018

saamalik closed this Jan 23, 2018

saamalik reopened this Jan 23, 2018

Merge branch 'master' into ctrl-alt-sequences

e478918

Merge branch 'master' into ctrl-alt-sequences

baaf61b

Reimplement using map

0104e42

* Reimplemented reg + shift alt digits and characters using a map * Add test cases for digits

saamalik added 3 commits January 28, 2018 16:54

Merge branch 'master' into ctrl-alt-sequences

f8fbdf3

Add mapping for backward slash

9ade1f0

* Add mapping for backward slash * Fix mapping for single/double quote

Merge branch 'master' into ctrl-alt-sequences

73e0db1

saamalik added 2 commits February 8, 2018 12:03

Merge branch 'master' into ctrl-alt-sequences

6dc49b7

Merge branch 'master' into ctrl-alt-sequences

18f6556

saamalik mentioned this pull request Feb 11, 2018

shift + alt + 3 shortcut support #1267

Closed

Merge branch 'master' into ctrl-alt-sequences

51d2064

Merge branch 'master' into ctrl-alt-sequences

8324462

Tyriar approved these changes Feb 21, 2018

View reviewed changes

Tyriar merged commit 62cf093 into xtermjs:master Feb 21, 2018

Tyriar added this to the 3.2.0 milestone Feb 21, 2018

Tyriar self-assigned this Feb 21, 2018

twifty mentioned this pull request Mar 6, 2018

'Ctrl + Shift + C' combination #1312

Closed

saamalik deleted the ctrl-alt-sequences branch March 11, 2018 05:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Additional alt and control sequences #1231

Additional alt and control sequences #1231

saamalik commented Jan 22, 2018 •

edited by Tyriar

Loading

saamalik Jan 22, 2018

saamalik Jan 22, 2018

saamalik commented Jan 23, 2018 •

edited

Loading

Tyriar commented Jan 25, 2018

saamalik commented Jan 26, 2018

saamalik commented Jan 27, 2018 •

edited

Loading

saamalik commented Jan 27, 2018 •

edited

Loading

saamalik commented Jan 31, 2018

Tyriar commented Jan 31, 2018

saamalik commented Feb 1, 2018

Tyriar commented Feb 2, 2018

saamalik commented Feb 14, 2018

Tyriar left a comment

saamalik commented Feb 22, 2018

Additional alt and control sequences #1231

Additional alt and control sequences #1231

Conversation

saamalik commented Jan 22, 2018 • edited by Tyriar Loading

saamalik Jan 22, 2018

Choose a reason for hiding this comment

saamalik Jan 22, 2018

Choose a reason for hiding this comment

saamalik commented Jan 23, 2018 • edited Loading

Tyriar commented Jan 25, 2018

saamalik commented Jan 26, 2018

saamalik commented Jan 27, 2018 • edited Loading

saamalik commented Jan 27, 2018 • edited Loading

saamalik commented Jan 31, 2018

Tyriar commented Jan 31, 2018

saamalik commented Feb 1, 2018

Tyriar commented Feb 2, 2018

saamalik commented Feb 14, 2018

Tyriar left a comment

Choose a reason for hiding this comment

saamalik commented Feb 22, 2018

saamalik commented Jan 22, 2018 •

edited by Tyriar

Loading

saamalik commented Jan 23, 2018 •

edited

Loading

saamalik commented Jan 27, 2018 •

edited

Loading

saamalik commented Jan 27, 2018 •

edited

Loading